Comments (7)
Hey! Thanks for saying so, I think it's starting to come together.
The "Building container..." step can sometimes take a couple of minutes -- it's downloading a big fat Ubuntu base image. It probably takes longer than it needs to.
The good news is that once it downloads the Ubuntu base image, Docker caches that layer, so you won't need to wait that long again.
from melpazoid.
More than two days have passed. It's more natural to assume that docker builds are stuck rather than taking that long.
Or, if this package do a docker pull
, please show the information without hiding it so that the user knows how long to wait.
There is no status and I feel uneasy about being kept waiting.
from melpazoid.
Yeah -- there is a --quiet
flag that is enabled. If you edit the Makefile and remove it and then type "make test" you should see the output scroll. Two days is probably too long. :)
The other thing you could do to diagnose it is monitor your network activity. Most of what the docker build is doing should be downloading stuff.
If you check the build logs they mostly take around three minutes, and the majority of that is spent building the container.
from melpazoid.
Same result... Some dependencies missing?
$ git diff
diff --git a/Makefile b/Makefile
index 9916010..ba07dba 100644
--- a/Makefile
+++ b/Makefile
@@ -15,5 +15,5 @@ term: image
.PHONY: image
image:
- @docker build --build-arg PACKAGE_NAME --quiet \
+ @docker build --build-arg PACKAGE_NAME \
--tag ${IMAGE_NAME} -f Dockerfile .
$ MELPA_PR_URL=https://github.com/melpa/melpa/pull/6725 make
python melpazoid.py
Cloning https://github.com/srfi-explorations/emacs-srfi
Building container... 🐳
^CTraceback (most recent call last):
File "melpazoid.py", line 563, in <module>
check_melpa_pr(os.environ['MELPA_PR_URL'])
File "melpazoid.py", line 495, in check_melpa_pr
return run_checks(recipe, elisp_dir, clone_address, pr_data)
File "melpazoid.py", line 82, in run_checks
check_containerized_build(_package_name(recipe))
File "melpazoid.py", line 91, in check_containerized_build
output = subprocess.check_output(['make', 'test', f"PACKAGE_NAME={package_name}"])
File "/usr/lib/python3.8/subprocess.py", line 411, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "/usr/lib/python3.8/subprocess.py", line 491, in run
stdout, stderr = process.communicate(input, timeout=timeout)
File "/usr/lib/python3.8/subprocess.py", line 1011, in communicate
stdout = self.stdout.read()
KeyboardInterrupt
make: *** [Makefile:6: run] Interrupt
from melpazoid.
Try using "make test" instead -- the python subprocess module unfortunately buffers all the output, so you won't see what's going on in the container. Don't worry, "make test" will pick up where the build left off, so you won't have to specify MELPA_PR_URL, etc.
from melpazoid.
Also, I'm excited to get this working for you too, so don't hesitate to ask lots of questions here! I'd also like to incorporate the indentation checks you added.
from melpazoid.
Closing this for now, but let me know if there is more to reopen for. (Or maybe we open another issue.)
from melpazoid.
Related Issues (20)
- Check for existing packages by the same name HOT 3
- Add support for local builds HOT 1
- Using only the license checker HOT 6
- Mention compilation features in docs HOT 1
- Sharp-quoting inside define-obsolete-function-alias forms HOT 1
- Setting LOCAL_REPO in the GitHub Actions workflow HOT 2
- Conflict on installing requirements.txt HOT 2
- Issue with pkg-info erroring on present package-lint HOT 1
- Suggest using %F for `%Y-%m-%d`[uppercased y] time string only HOT 2
- file-missing Searching for program: "No such file or directory git" HOT 1
- meta: support for podman HOT 8
- Deprecated warnings for melpazoid actions HOT 1
- Warning: docstring has wrong usage of unescaped single quote HOT 2
- [FEATURE] Warn when package references external private symbols HOT 1
- Warning even when fset is used to define a prefix command HOT 1
- update setup-python version HOT 4
- Trouble using `melpazoid` on Windows HOT 3
- Add AUR package
- [feature request] Print line in code for lints and diagnostics
- Checking homepage URLs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from melpazoid.