rithmschool / cams-app-client Goto Github PK

Right now, after you've gone through an assessment and had your video recorded, you can click on the link and record the video again. Once the video has been recorded, the assessment shouldn't be accessible by patients any more.

We have an upload bar for doctors when they upload their own videos, we could recycle it for patients once they've completed their assessment.

1. go to /login and log in.
2. go to /login again, and the form appears.

either during playlist creation or edit

Full screen if possible, but definitely bigger than their current size.

When I run the app locally, sometimes it seems like i'm being redirected to login before authentication is completed - i get a 401 and my playlists don't show up. Doesn't happen consistently, and when i refresh the page everything shows up normally.

Make sure that for files exporting a default component, the file name matches the component name. This currently isn't the case for a couple of files (e.g. Login vs LoginForm)

app is sending a bunch of PATCH requests unnecessarily:

first, this request only needs to be sent when drag and drop is happening to re-order screens. Second, it would be better to only fire this event once (e.g. on a componentWillUnmount).

Some consistency around user/doctor assessment/patient

There are several client-side requests being made in the app that require an authorization header be sent. Rather than duplicating code across components and functions, you can tell axios to set this header on every request. App should be refactored so that on login, something like this happens:

axios.defaults.headers.common['Authorization'] = AUTH_TOKEN;

On logout, this default header can then be deleted.

I can't tell if it is being used by bootstrap or by our main.js as createElement.

https://developer.mozilla.org/en-US/docs/Web/API/Navigator/getUserMedia

try using navigator.mediaDevices.getUserMedia instead

spaceBarClick and index are marked as required but their values are undefined when loading assessment page

refactor these out. They're deprecated: https://facebook.github.io/react/docs/refs-and-the-dom.html

E.g. PatientHome has props of assessment_id and screenCount

/playlist/home needs some refactoring to accommodate the Question model. Right now, only videos get shown when a patient goes through the playlist, not questions.

There are quite a few places where the same code is being written to grab the token from localStorage, decode it, and find the logged in user's id. To remove duplication, it would be better to refactor this into a helper.

Needs a test that mocks the BrowserDetect object in order to get a different snapshot.

indentation is a little inconsistent. Use 2 spaces throughout. Some files need to be looked over and fixed.

Right now, if the camera isn't functioning, you can still progress through the assessment. (Thanks for catching this @aalanders!)

• In the patient assessment view, use flexbox to center the content on the screen
• In the patient assessment view, remove the index displayed above the timeline
• In the patient assessment view, move the timeline to the top instead of the bottom, make sure it's centered on all devices, and remove margin (styling right now is hard-coded and device dependent: https://github.com/rithmschool/cams-app-client/blob/master/src/horizontal-timeline/EventsBar.js#L44)
• In the patient assessment view, add more design to differentiate dots in the past from dots in the future in the timeline
• In the patient assessment view, center the timer and add more design elements
• Improve the design of the screen creation after making a playlist (owned by @aricWL)
• Improve the copy in the emails being sent to patients for their assessments
• On the doctor assessment dashboard, format the timestamp nicely and order by most recent
• On the doctor assessment dashboard, style the button to download a link

There's a lot of markup inside of the render method that could probably be pulled out into a few different component files.

UI could use some improvement; there's no visual cue to press space bar after the timer is finished or a video is complete, for example. A little more visual polish overall would be good too.