robaimes / module-notorama Goto Github PK

Hi,

The massive outage of Fastly, broke Vimeo and therefor broke the vimeo player require.js dependency and therefor broke the swatch renderer mixin.

Looking into a possible fix, but think vimeo player should not be loaded through require js and should not be mandatory for loading notorama.

How to add a custom caption

Some of our product titles contain apostrophes or quotations. This breaks the json format for the product view image.

This is the full json:
{"initialImages":"[{\"thumb\":\"https:\\\/\\\/myron-m2.toolmax.nl\\\/media\\\/catalog\\\/product\\\/cache\\\/79e1e7bedd753adfc5e16d432c6f3132\\\/m\\\/a\\\/makita_dub361z.jpg\",\"img\":\"https:\\\/\\\/myron-m2.toolmax.nl\\\/media\\\/catalog\\\/product\\\/cache\\\/7c515c7d7aacb26b754ce8379b9a25b3\\\/m\\\/a\\\/makita_dub361z.jpg\",\"full\":\"https:\\\/\\\/myron-m2.toolmax.nl\\\/media\\\/catalog\\\/product\\\/cache\\\/e0d1dcca11a1ec209e27b8dfb2eb5b8c\\\/m\\\/a\\\/makita_dub361z.jpg\",\"caption\":\"Makita DUB361Z 2x18 V Bladblazer | zonder accu'sen lader (Accu Bladblazer) 1\",\"position\":\"2\",\"isMain\":true,\"type\":\"image\",\"videoUrl\":null},{\"thumb\":\"https:\\\/\\\/myron-m2.toolmax.nl\\\/media\\\/catalog\\\/product\\\/cache\\\/79e1e7bedd753adfc5e16d432c6f3132\\\/m\\\/a\\\/makita_tuinmachinesfb_14_1_41.jpg\",\"img\":\"https:\\\/\\\/myron-m2.toolmax.nl\\\/media\\\/catalog\\\/product\\\/cache\\\/7c515c7d7aacb26b754ce8379b9a25b3\\\/m\\\/a\\\/makita_tuinmachinesfb_14_1_41.jpg\",\"full\":\"https:\\\/\\\/myron-m2.toolmax.nl\\\/media\\\/catalog\\\/product\\\/cache\\\/e0d1dcca11a1ec209e27b8dfb2eb5b8c\\\/m\\\/a\\\/makita_tuinmachinesfb_14_1_41.jpg\",\"caption\":\"DUB361Z 2x18 V Bladblazer | zonderaccu's en lader\",\"position\":\"3\",\"isMain\":false,\"type\":\"image\",\"videoUrl\":null}]"}

I'm using this plugin on magento 2.3.5 and it's amazing. I have some configurable products which have different images , if i change the subproduct form the dropdown in frontend the slick not resizes at right width and appears blank (like screenshot attached). The crazy thing is if I play changing options then the image appears good😅