Comments (6)
Any GPOS support beyond single and pair positioning is almost certainly broken. It's weird that the two versions give different results. I don't recall changing anything in the core. Are these from the same binary?
KeyError
Yeah. This is a feaLib issue. I'm going to open a PR for that when I have a chance. It needs to raise a FeaLibError with a note about the unknown glyph.
from compositor.
This is not really a feaLib issue as I was just reading binaries files.
I fixed it by returning the fallback glyph whenever a glyph is requested that does not exist
maybe I have to fork-patch and pull those little changes
gr Frederik
www.typemytype.com
On 31 Jan 2016, at 02:27, Tal Leming [email protected] wrote:
Any GSUB support beyond single and pair positioning is almost certainly broken. It's weird that the two versions give different results. I don't recall changing anything in the core. Are these from the same binary?
KeyError
Yeah. This is a feaLib issue. I'm going to open a PR for that when I have a chance. It needs to raise a FeaLibError with a note about the unknown glyph.
—
Reply to this email directly or view it on GitHub #14 (comment).
from compositor.
Got it. I'll fix it.
I've found where the value difference is happening. I'm trying to figure out a way to fix it now. (It's a chicken or egg issue.)
from compositor.
So, here's what is happening on the value difference. Previously, the glyph records resulting from GSUB processing had their advance width set before processing GPOS. See here. This advance width value is used internally to calculate x placement values in some of the GPOS subtable types. For example.
The issue that I'm stuck on is that the new LayoutEngine object doesn't know anything about glyphs and so it therefore doesn't have an advance width to preset before processing GPOS. I can modify the LayoutEngine object to have something like a hmtx table. However, I'm not certain that my GPOS code is correct (for subtable types beyond basic pair positioning), so the first thing I want to do is get that working with a high degree of certainty. I'll open a new issue for that and then come back to this.
from compositor.
the layout engine could call willBeginProcessGSUB
didProcessGSUB
and the same for GPOS
the font object could then add the overwrite didProcessGSUB
and adjust the advanceWidth values of the glyph records
gr Frederik
www.typemytype.com
On 01 Feb 2016, at 05:23, Tal Leming [email protected] wrote:
So, here's what is happening on the value difference. Previously, the glyph records resulting from GSUB processing had their advance width set before processing GPOS. See here. https://github.com/typesupply/compositor/blob/db296a7ec7d0b09b58791231f356b511b8604f90/Lib/compositor/__init__.py#L211 This advance width value is used internally to calculate x placement values in some of the GPOS subtable types. For example. https://github.com/typesupply/compositor/blob/master/Lib/compositor/subTablesGPOS.py#L363
The issue that I'm stuck on is that the new LayoutEngine object doesn't know anything about glyphs and so it therefore doesn't have an advance width to preset before processing GPOS. I can modify the LayoutEngine object to have something like a hmtx table. However, I'm not certain that my GPOS code is correct (for subtable types beyond basic pair positioning), so the first thing I want to do is get that working with a high degree of certainty. I'll open a new issue for that and then come back to this.—
Reply to this email directly or view it on GitHub #14 (comment).
from compositor.
the layout engine could call
willBeginProcessGSUB
didProcessGSUB
and the same for GPOSthe font object could then add the overwrite
didProcessGSUB
and adjust the advanceWidth values of the glyph records
All GPOS processing may need the advanced width set for proper calculation in the complex subtable types. So it can't just be in the subclass.
from compositor.
Related Issues (9)
- Consider a global class registry.
- setCMAP HOT 2
- Examine the implementation of GPOS lookup types 3, 4, 5 & 6. HOT 1
- Loading font: AttributeError: Coverage HOT 4
- Look at Cairo demo by Brook
- GlyphClassDef AttributeError: Format HOT 2
- Right-to-left problem with "mark" GPOS
- test Coverage object if it has a Format attr HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compositor.