Comments (15)
Correct.
(Didn't know anyone relies on it. I'm open to reconsidering that. But basically the reason was that the "Format" is not needed to use the coverage data, and best format is automatically chosen when compiling the font and the Format set on the object is ignored. The only use it can possibly have is informational.
from compositor.
FontTools is very frequently used to inspect the data inside of a font, not just to modify it and recompile it. CoverageFormat is an official part of the spec.
Is there a change list somewhere of all the things that you've done since forking from the original FontTools? We're running into lots of things so it would be good to have something to review.
from compositor.
+1 on @typesupply's request
There are several things that I use/have written over the past decade that rely on FontTools working in a stable way. A change list would be very helpful.
from compositor.
This can be closed now.
from compositor.
This can be closed now.
I am still experiencing this bug.
from compositor.
This can be closed now.
I am still experiencing this bug.
Humm. Even after this commit:
fonttools/fonttools@6851f66
from compositor.
Humm. Even after this commit:
fonttools/fonttools@6851f66
Yea.
from compositor.
Humm. Even after this commit:
fonttools/fonttools@6851f66Yea.
Can you please debug it then?
from compositor.
@behdad Should buildCoverage in otlLib set the Format attribute? Currently in feaLib neither preWrite() nor postRead() methods of Coverage are called so no Format attribute is set.
from compositor.
Ah, ok, so you are not actually loading from binary. Then that's a separate issue...
Tal, would be nice if you can merge the original suggestion. Or better, just remove the CoverageFormat member completely. There is no use for the Format of a Coverage table as the FontTools layer hides the different formats.
I'm hesitant to add a hack in otlLib to add Format, which would be wrong. Just told me today that he has updated his code that relied on the Coverage.Format to avoid it. Perhaps it's time to accept that my fork of fonttools is what everyone is using?
from compositor.
would be nice if you can merge the original suggestion.
I don't know what you are hinting at here but actually, yeah, CoverageFormat isn't internally used in the code so presumably there's no reason to keep it.
I'm submitting a PR for that (I assume if it gets merged, then you are free to revert your patch that keeps the Format attribute around).
from compositor.
I'll remove CoverageFormat. No big deal. Compositor abstracts the different formats as well.
from compositor.
@typesupply Put you a PR up for it.
from compositor.
Done. Thanks!
from compositor.
Thanks Tal.
from compositor.
Related Issues (9)
- Consider a global class registry.
- setCMAP HOT 2
- somehow the XP and YP are different compared a pre LayoutEngine version of compositor HOT 6
- Examine the implementation of GPOS lookup types 3, 4, 5 & 6. HOT 1
- Loading font: AttributeError: Coverage HOT 4
- Look at Cairo demo by Brook
- GlyphClassDef AttributeError: Format HOT 2
- Right-to-left problem with "mark" GPOS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compositor.