GithubHelp home page GithubHelp logo

Comments (7)

sea-bass avatar sea-bass commented on June 28, 2024 1

@EzraBrooks is also active, and I can almost guarantee he and I would both be very much pro type hints! See b434598 for example.

from rosbridge_suite.

EzraBrooks avatar EzraBrooks commented on June 28, 2024 1

I'd be happy to help review a PR for this. The serialization and deserialization in this package is pretty hard for me to wrap my head around - especially where there's special cases for certain types, which exist in a few places - and it would be great to have static type checking to help trace through it.

from rosbridge_suite.

yoelbassin avatar yoelbassin commented on June 28, 2024

@sea-bass would love to hear your opinion about this one before I start refactoring stuff locally :)
BTW are there any other active maintainers?

from rosbridge_suite.

yoelbassin avatar yoelbassin commented on June 28, 2024

especially where there's special cases for certain types, which exist in a few places

Could you mention some of the places you've seen this, so I would skim through them? :)

from rosbridge_suite.

yoelbassin avatar yoelbassin commented on June 28, 2024

Well, after playing with it a little I found the pydantic version that rosdep supports is at most 1.10 which is a little outdated. The newest pip version is 2.6 where breaking changes were introduced since the 1.* versions.

I'm not sure what approach I should take, either implementing a simpler version of pydantic on dataclass (which really isn't ideal), or using the older pydantic version.

What do you think would be the better approach?

from rosbridge_suite.

EzraBrooks avatar EzraBrooks commented on June 28, 2024

here's one such odd place, where the library implicitly converts uint8[] to a base64 string. This one in particular actually bit me recently on a project.

# Special case for uint8[], we encode the string

from rosbridge_suite.

EzraBrooks avatar EzraBrooks commented on June 28, 2024

It looks like Pydantic is at version 1.10 even on Ubuntu Noble, which releases this month (April 2024), so it seems we should target the older version.

from rosbridge_suite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.