GithubHelp home page GithubHelp logo

Comments (3)

arv avatar arv commented on June 16, 2024
  • PullRequest should not really parameterized. That was an internal implementation detail that leaked. cookie should always be ReadonlyJSONValue which already includes null.

  • We do not want to support Date. These are things that are JSON as specified on https://json.org. We only want things that round trip. We do not actually use JSON.stringify or toJSON any more.

from replicache.

user72356 avatar user72356 commented on June 16, 2024
  • PullRequest should not really parameterized. That was an internal implementation detail that leaked. cookie should always be ReadonlyJSONValue which already includes null.

I don't understand this. I'm working with TS in strict mode and I'm not allowing the any type. If PullRequest is an implementation detail that was leaked, how am I to use req.body? By recreating my own type from the documentation?

  • We do not want to support Date. These are things that are JSON as specified on https://json.org. We only want things that round trip. We do not actually use JSON.stringify or toJSON any more.

That's fair, but how do you suggest working with dates? Should I manually (de)serialize them within my own code?

from replicache.

arv avatar arv commented on June 16, 2024

PullRequest is not an implementation detail. The thing that was a mistake to "leak" was the type parameter. cookie should always be ReadonlyJSONValue. This has been fixed for the next release. Sorry for the confusion.

from replicache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.