Comments (2)
Looked into this more, and it's going to be difficult (or impossible) to give much useful info (e.g. the instance's full name) in these errors because the DOM is necessarily incomplete in the middle of a deserialization operation.
Maybe instead of more specific errors, we could just do a lossy conversion for non UTF-8 Variant::String
properties? The main drawback is just the fact the original data would be altered, and there may be legitimate uses for non UTF-8 string properties!
Alternatively, we could start reading Variant::String
props into a Vec<u8>
instead of a String
. This would be more correct, but it would be a breaking change and makes string properties more complicated to work with for consumers.
d��������������ng…i got owned…
from rbx-dom.
Alternatively, we could start reading Variant::String props into a Vec instead of a String. This would be more correct, but it would be a breaking change and makes string properties more complicated to work with for consumers.
This actually sounds great for Lune as a consumer since we could, in many cases, skip the entire conversion step between dom string -> rust string -> lua (c) string. We could also unify some code we have for differences in handling with normal strings / binary strings. I can't really speak for Rojo or any other tools (are there any other than Remodel/Lune?) though.
from rbx-dom.
Related Issues (20)
- `Sound.RollOffMinDistance` and `Sound.RollOffMaxDistance` need to be aliased
- `UniqueId::now` fallback default in binary serializer can cause `UniqueId` collisions HOT 2
- Roblox loads whatever property is last in the file rather than whichever one is newest HOT 8
- Support for async writer and reader HOT 4
- Setting `BaseScript.Enabled` doesn't affect anything HOT 1
- #332 breaks compatibility HOT 2
- Concretely define and use terms like `alias`, `canonical`, etc.
- Support more than one root-level Instance in rbx_dom_weak
- rbx_reflector is inconsistent with storing default values for properties HOT 1
- rbx_reflector does not read Studio saving the default place file correctly sometimes
- Releases should be more automated HOT 1
- rbx_dom_lua should be a Wally package HOT 1
- Memory leak in SharedString HOT 10
- `TerrainMaterials` should implement `FromStr`
- Support for `SecurityCapabilities` tag in XML files HOT 1
- Add support for `Enum`-typed attributes HOT 2
- rbx-dom doesn't care about select properties important for correctness and least surprise HOT 7
- `Model.WorldPivotData` needs a custom property setter/getter HOT 2
- Failed to deserialize Configuration.AttributesSerialize HOT 1
- Property write failure warning should include the instance's full name
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rbx-dom.