GithubHelp home page GithubHelp logo

Comments (1)

kennethloeffler avatar kennethloeffler commented on June 9, 2024

This is happening because rbx_reflector is using DecodePropertyBehavior::IgnoreUnknown when deserializing the defaults place, so it will only apply defaults for properties that are already present rbx_xml's built-in database:

pub fn apply_defaults(
database: &mut ReflectionDatabase,
defaults_place: &PathBuf,
) -> anyhow::Result<()> {
let file = BufReader::new(File::open(defaults_place).context("Could not find defaults place")?);
let decode_options = rbx_xml::DecodeOptions::new()
.property_behavior(rbx_xml::DecodePropertyBehavior::IgnoreUnknown);

This is not the desired behavior. We should be using DecodePropertyBehavior::NoReflection and then using the in-progress database (rather than the one in rbx_xml) to do reflection on the defaults place, similar to generate_reflection.

from rbx-dom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.