rokups / imgui Goto Github PK

Some pointers

• Introduce e.g.

#define IMGUI_ENABLE_FREETYPE,
ImFontAtlasFlags_RasterizerStbTruetype,
ImFontAtlasFlags_RasterizerFreeType,
ImFontAtlasFlags_RasterizerMask_
ImFontAtlasFlags_RasterizerDefault_

• Default can change to Freetype if the define is disabled so it means just enabling IMGUI_ENABLE_FREETYPE in imconfig.h can work for example_null
• ImFontAtlas::Build() may select which build function to run based on those flags
• Add extra commentary around Build() to clarify that in theory users could call those functions directly (which is what people using imgui_freetype today are already doing)
• imgui_draw.cpp can include imgui_freeetype.h if IMGUI_ENABLE_FREETYPE is defined
• Add support in example_null/main.cpp, update imgui_freetype's readme.
• Will need to replace imgui_freetype BuildFontAtlas()'s extra_flags by e.g. SharedRasterizerFlags in ImGuiFontAtlas. maybe we could remove that parameter from BuildFontAtlas() - will break build of people using imgui_freetype but then they have a clear path in, being requested to set SharedRasterizerFlags if they used them.
• Update the demo in imgui_freetype README, it is also in imgui_private/mains/main_freetype_dx11
• Maybe verify that #include <ft2build.h> in imgui_freetype.cpp is the "standard way" of accessing freetype (vs some #include <somefolder/ft2build.h> or #include "ft2build.h" so probably need to check freetype docs/examples
• etc.

Hey @gleblebedev, could you try this commit and see if it fixes state restoration issue? It is meant to fix your issue upstream. Or maybe you could share code/instructions how to reproduce this issue locally so i could test myself?

Relevant links for myself:
https://gamedev.stackexchange.com/questions/99236/what-state-is-stored-in-an-opengl-vertex-array-object-vao-and-how-do-i-use-the