romanzipp / laravel-seo

SEO package made for maximum customization and flexibility

Laravel SEO

A SEO package made for maximum customization and flexibility.

Documentation

The full package documentation can be found on romanzipp.github.io/Laravel-SEO

Testing

./vendor/bin/phpunit

License

The MIT License (MIT). Please see License File for more information.

laravel-seo's Issues

Duplicate tags

Describe the bug
Not sure if this qualifies as a bug.
Some tags are rendered twice while others are overridden.

To Reproduce
Steps to reproduce the behavior:

1. Create AddSeoDefaults middleware
2. Add seo()->title(config('app.name')); to AddSeoDefaults as fallback title
3. In your controller or elsewhere add seo()->title('Something else');
4. Title is as expected "Something else"
5. Add seo()->meta('robots', 'index, follow') to AddSeoDefaults as fallback tag
6. In your controller or elsewhere add seo()->meta('robots', 'noindex, nofollow')
7. <meta name="robots" content="index, follow"> AND <meta name="robots" content="noindex, nofollow"> are rendered.

Expected behavior
All tags should only be rendered once and be rendered as they are called the last in the stack.

Use with jigsaw: "A facade root has not been set."

Hello @romanzipp,

I'm trying to get the package working with jigsaw. I've updated this starter and wanted to add Laravel SEO to it. I wonder if it's possible, below are steps to reproduce the issue:

To Reproduce
Steps to reproduce the behavior:

1. Go to clone starter repo: git clone https://github.com/spekulatius/jigsaw-clean-blog
2. composer install && yarn
3. Add Laravel SEO: composer require romanzipp/laravel-seo
4. Add PHP block to master.blade.php: @php $seo = \romanzipp\Seo\Facades\Seo::make(); @endphp
5. Run yarn dev
6. See error

I'm not sure if it's possible to make the package work with jigsaw, it might be desirable tho.

Thanks,
Peter

URL query parameters get escaped

To Reproduce

seo()->twitter('player', 'http://example.com/something?video=123&clip=456')

Expected behavior

<meta name="twitter:player" content="http://example.com/something?video=123&clip=456" />

Actual behavior

<meta name="twitter:player" content="http://example.com/something?video=123&amp;clip=456" />

Input as a nested array structure?

Hello @romanzipp

Your SEO package looks great, well thought out! Thank you for maintaining it!

I'm consider to use it in a package I'm building. I was wondering if there is a simple way to pass a nested array structure to process into header tags. I'm thinking of something like this:

$data = [
    'title' => 'abc',
    'description' => 'bla bla...',

    'twitter' => [
        'card' => 'summary',
        'creator' => '@romanzipp'
    ]
];

// Rendering and returning the result
seo()->render($data);

Is this possible?

Cheers,
Peter

PHP8 support

Hi,
would it be support for php8?
On composer update i get the following:
"romanzipp/laravel-seo[2.1.0, ..., 2.1.5] require php ^7.1 -> your php version (8.0.0) does not satisfy that requirement"

Further Shorthand Setters

Hey @romanzipp

I was wondering what you think about these for further shorthand setters:

• canonical for the canonical URL
• image for the meta and social sharing images
• keywords for the keywords meta-tag and potentially the <meta property="article:tag" content="keyword" />

Generally, do you think it makes sense to have the meta-tags for article: similar to og/twitter?

Happy to help out!

Cheers,
Peter

Canonical Link

Describe the bug

Hello @romanzipp

I've used the shorthand for the canonical link and it added a meta-tag instead of the expected link-tag. I googled and couldn't find any information on a meta tag - only the typical <link ... >. Could this be a mistake? If so I'm happy to look into and provide a fix.

Cheers,
Peter

Add an option to render HTML5 tags

Is possible to set an option to render HTML5 tags instead XHTML?

Example:

<meta name="description" content="Laravel" />

to

<meta name="description" content="Laravel">

How to set <script> attributes such as async and defer?

Hello @romanzipp

I was wondering how one would set async or defer on Script. As far as I've seen it isn't possible at the moment. Is this correct? With addAttribute being protected I can't see a way to set it. Do I miss the obvious way here?

Cheers,
Peter

Add fetching preload/prefetch links from mix-manifest file

Describe the solution you'd like
Add a feature to read asset urls from the mix-manifest.json file generated by laravel-mix and append <link rel="prefetch"> or <link rel="preload"> elements.

Laravel Octane and tag duplication

Describe the bug
When using the plugin with Laravel Octane tags are duplicated. First off the title tag gets duplicated then anything added to the AddSeoDefaults middleware. I followed your tutorial(https://romanzipp.github.io/Laravel-SEO/example-app.html) on setting everything up including Providers and Middleware .

To Reproduce
Steps to reproduce the behavior:

1. Install the plugin and set everything as defined here: https://romanzipp.github.io/Laravel-SEO/example-app.html
2. Install Laravel Octane (https://github.com/laravel/octane)
3. Run app and see problems

Expected behavior
The tags should not be duplicated.

Screenshots
https://i.postimg.cc/WbZhkY6j/Screenshot-2022-09-21-at-13-12-26.png

Additional context
I think this happens because Octane keeps requests in memory so somehow the plugin should reset the added metadata.

Struct attribute value '0' won't get rendered

Describe the bug
Struct attribute value '0' won't get rendered

To Reproduce

seo()->addMany([
    Meta::make()->attr('http-equiv', 'Cache-Control')->content('no-cache, no-store, must-revalidate'),
    Meta::make()->attr('http-equiv', 'Pragma')->content('no-cache'),
    Meta::make()->attr('http-equiv', 'Expires')->content('0'),
]);

<meta http-equiv="Expires" content />

Expected behavior

<meta http-equiv="Expires" content="0" />