ronanguilloux / isocodes Goto Github PK

see https://scrutinizer-ci.com/g/ronanguilloux/IsoCodes/inspections/35869a53-4d36-4c30-be3e-b36537f42af7/issues/files/src/IsoCodes/Isin.php?status=new&orderField=path&order=asc&honorSelectedPaths=0#inspectioncomment-4859364

Hi and thanks for this project, found a lot of missing validators.

I'm planning to wrap them with a Symfony Validator extension, I'll speak about it later! :-)

Have you plan to normalize code on command to get it on full English?

Could make thinks easier for world wide contributing.

Some french code here, for example: https://github.com/ronanguilloux/IsoCodes/blob/master/src/IsoCodes/OrganismeType12NormeB2.php
And spanish comments here: https://github.com/ronanguilloux/IsoCodes/blob/master/src/IsoCodes/Nif.php

Regards

• See https://github.com/symfony/symfony/blob/2.7/CONTRIBUTING.md
• See https://github.com/ronanguilloux/IsoCodes/blob/master/README.md#contributing-code
• Remember to tell about the make quality & make cs-fix tasks

Suggest ext-bcmath on composer.json on throw error on needed validator.

See related #7

Propose a code of conduct guidelines

cf. http://www.credit-card.be/BankAccount/ValidationRules.htm

http://www.ismn-international.org/publications/newsletter10/othersys.html

SsnTest is failing if the Ssn.php file has CRLF end of lines instead of just LF. I tried to fix it using some line normalization function but it didn't work for unknown reason.

This should be considered a bug, the script should not depend on the EOL style used since that can be changed unpredictably when deploying for example.

Currently you have a few zipcodes available, perhaps add them all automatically?

Instead of creating a method for each country, perhaps create an array with data for all countries?

This list exists but is deprecated:
http://unicode.org/cldr/trac/browser/trunk/common/supplemental/postalCodeData.xml

Links to:
http://i18napis.appspot.com/address
http://i18napis.appspot.com/address/data/GB
"zip": "GIR[ ]?0AA|((AB|AL|B|BA|BB|BD|BH|BL|BN|BR|BS|BT|BX|CA|CB|CF|CH|CM|CO|CR|CT|CV|CW|DA|DD|DE|DG|DH|DL|DN|DT|DY|E|EC|EH|EN|EX|FK|FY|G|GL|GY|GU|HA|HD|HG|HP|HR|HS|HU|HX|IG|IM|IP|IV|JE|KA|KT|KW|KY|L|LA|LD|LE|LL|LN|LS|LU|M|ME|MK|ML|N|NE|NG|NN|NP|NR|NW|OL|OX|PA|PE|PH|PL|PO|PR|RG|RH|RM|S|SA|SE|SG|SK|SL|SM|SN|SO|SP|SR|SS|ST|SW|SY|TA|TD|TF|TN|TQ|TR|TS|TW|UB|W|WA|WC|WD|WF|WN|WR|WS|WV|YO|ZE)(\\d[\\dA-Z]?[ ]?\\d[ABD-HJLN-UW-Z]{2}))|BFPO[ ]?\\d{1,4}",

I would also suggest that the country code is easier to use, instead of the name?

https://scrutinizer-ci.com/g/ronanguilloux/IsoCodes/inspections/764a4bde-73e4-4a8d-9696-8f90b7902cc9/issues/files/src/IsoCodes/Insee.php?status=existing&orderField=path&order=asc

raising "This test executed code that is not listed as code to be covered or used" warnings

PHP tools (phpunit / phpcs / phpmd...) should be separated from project dependencies because:

• Lot of dependencies to download for only one project.
• Could easily make conflict

Will make a PR proposition about that.

Would be great to have a .php-cs configuration file and some automation with a Makefile for example and Travis integration.

Like it was made here: sonata-project/SonataAdminBundle#3038

PR is coming.

http://phpunit.de/manual/current/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.data-providers may be a nice enhancement

http://www.braemoor.co.uk/software/vat.shtml

https://en.wikipedia.org/wiki/International_Standard_Audiovisual_Number

PHP is required to be compiled with "--enable-bcmath" for some checks but this is not mentioned in the documentation.
Please update the documentation or provide a fallback method if possible.

Thomas

PHP 5.3 is obsolete, EOL since Aug 2014

in composer.lock

The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. Run update to update them.

Posted from SensioLabsInsight

http://www.bfs.admin.ch/bfs/portal/fr/index/themen/00/05/blank/03.html

Luhn-based. May be an occasion for refactoring all Luhn-based validations

Remove $fromInstance flag from Ssn constructor and make it private.

Don't forget to remove the flag from getInstance constructor call too.

@ronanguilloux Can you add this todo on 2.0 milestone?

Related to #34.

ZipcodeException, etc.

in composer.json

The version field is present, it is recommended to leave it out if the package is published on Packagist.

Posted from SensioLabsInsight

See: https://packagist.org/packages/symfony/phpunit-bridge

PR is coming.

The requirements cannot be resolved on 5.3 currently, making the Travis job useless

http://www.gs1.org/how-calculate-check-digit-manually

see https://scrutinizer-ci.com/g/ronanguilloux/IsoCodes/issues/master/files/src/IsoCodes/Ssn.php?orderField=path&order=asc&honorSelectedPaths=0#inspectioncomment-4380617

Failed asserting that exception of type "PHPUnit_Framework_Error_Deprecated" is thrown:
See this hhvm build

It would be great to have a IsoCodesInterface interface which will be implemented by all IsoCodes validator.

This will make a proper code structure and make some more strict rules for another validator contributions.

This can be done now if we solve #12.

OrganismeType12NormeB2 seems to be the only one that accepting two arguments instead of one on validate method.

BTW, I not implemented it on my wrappers because I don't know how it works. More exactly, what the second parameter mean?

Can you give me some clarification about it?

Thanks.

(META-issue)

• http://formvalidation.io/validators/ : interesting ISO formats to discover, w/ validators to create

Test for this card number fails on windows because a number this long can't be stored as an integer. Instead it becomes a float and when converted into string it is 6.3041E+15 instead of 6304100000000008.

In my opinion CreditCard::validate should only allow string arguments or at least throw an exception if a float is passed as parameter to prevent this error.

Reminder: Make a PR with fast_finish option in order to have a final discussion about that.

Related: #26 #57.

See credit card, GTIN, etc. that duplicate Luhn

\IsoCodes\CreditCard::validate('abc')

will return true

Is anyone using HHVM here?

Cf. symfony/symfony#18922

I see on your README file that your NIF validator if for Spain codes (Número de Identificación Fiscal) but, stop me if I'm wrong, NIF codes are Europeans.

See here: http://ec.europa.eu/taxation_customs/taxation/tax_cooperation/mutual_assistance/tin/index_fr.htm

Are we speaking about the same NIF?

Is your NIF validator compliant with EU conventions?

Regards

https://boapi.googlecode.com/svn/trunk/src/php/

Find documented rules for Amex, Visa, MasterCard, etc.

This should be done for 2.0 release if #54 is accepted.

• http://formvalidation.io/validators/isin/
• https://en.wikipedia.org/wiki/International_Securities_Identification_Number

in .coveralls.yml, line 4

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

# for php-coveralls
src_dir: src
coverage_clover: build/logs/clover.xml
json_path: build/logs/coveralls-upload.json

Posted from SensioLabsInsight

http://www.gs1-128.info/

PHPUnit versions have deprecated the strict option, thus this message is shown for every invocation:

Deprecated configuration setting "strict" used

See #13 and https://travis-ci.org/ronanguilloux/IsoCodes/jobs/59845136

http://www.activebarcode.com/codes/?close=

https://en.wikipedia.org/wiki/International_Standard_Musical_Work_Code

in composer.lock

The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. Run update to update them.

Posted from SensioLabsInsight

The SSN validator is special. We have to instantiate it before use it for validation.

I think is for avoid code generation (generate('CA')) on each validation?

In this case, could we think about use it as a singleton class?

See here (FR): http://fr.wikipedia.org/wiki/Singleton_%28patron_de_conception%29#PHP_5

I suggest it because with this code design, I will have to instantiate it on each validation with my Symfony Validator wrapping.

Could work on it. This should be on a next major release.

/^(\+\d)*\s*(\(\d{3}\)\s*)*\d{3}(-{0,1}|\s{0,1})\d{2}(-{0,1}|\s{0,1})\d{2}$/