roogue / osu-collector-dl

Automatic Downloader for Osu!Collector

I am roogue

I can't code without ctrl-c ctrl-v




Hutao Sama

osu-collector-dl's Issues

[ BUG ]

Describe
When downloading big collections, the program does not finish downloading all the maps. After downloading about 500 filed from the collection, it just automatically closes without any warning and error or anything. The downloaded beatmaps are present in the folder but because it didn't download all of them, just closed on its own, only the ones it downloaded are present. FYI, the only thing I changed in the config file was changing the mode from 1 to 2 for the .osdb file.

To Reproduce
Steps to reproduce the behavior:

1. Download from the collection ...
2. Wait until the error occurs

Error log (If present):

===Some Error===

Expected behavior
I just expected the download to finish and the window to normally say that the download is finished and press Enter to exit.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional information:

• Operating System: [e.g. iOS]

Additional context
The collections I was trying to download were-
https://osucollector.com/collections/6059
https://osucollector.com/collections/488

Using a browser for this is way overkill and horribly slow

Not sure if you were aware but you can just pull full collections from the osu!collector api in a single request using the following:

https://osucollector.com/api/collections/{id}

Not really making a feature request since I already have my own program to do this but just wanted to let you know.

[ BUG ] Ratelimits

Describe
A clear and concise description of what the bug is.

To Reproduce
download a bunch of maps

418 (blocked ip from catboy.best)

Expected behavior
respect ratelimits

Screenshots

Additional context
Please handle 429 so your users don't get fucked over and end up being blocked off the mirror thank you very much

[ BUG ]

Describe
A clear and concise description of what the bug is.
tried to download but had error bellow

To Reproduce
Steps to reproduce the behavior:
open with/without admin, 4991>1, had error

1. Download from the collection 4991
2. Wait until the error occurs ?

Error log (If present):
Failed when downloading [1895541] , due to error: TypeError: fetch failed
Failed when downloading [1899986] , due to error: TypeError: fetch failed
Downloading [1895541]
Retrying [1895541]
Failed when downloading [1889779] , due to error: TypeError: fetch failed
Downloading [1899986]
Retrying [1899986]
Failed when downloading [1872831] , due to error: TypeError: fetch failed
Downloading [1895541]
Retrying [1895541]
Downloading [1889779]
Retrying [1889779]
Downloading [1899986]
Retrying [1899986]
Downloading [1872831]
Download completed.

===Some Error===

Expected behavior
average? download?

Screenshots
If applicable, add screenshots to help explain your problem.

Additional information:
if im opening without admin perms, i have this error:

An error occurred: Error: 11:40:47 | [OcdlError]: FOLDER_GENERATION_FAILED - Error occurred while generating folder
Error: EPERM: operation not permitted, mkdir 'C:\apps\win-x64\Easy 200-300pp HDDT Maps [500+ Maps]'

• Operating System: [e.g. iOS]
  windows 10
  Additional context
  i didnt touch config.

[Suggestion] Option to only generate .osdb

Since Collection Manager can be used to download missing beatmaps, it would be nice if there was an option to only generate the .osdb file and use Collection Manager to download the beatmaps so that the already existing maps don't have to be downloaded again.

Ability to download as collection.db

It would be nice if this could be added since there are many people who want to have their beatmaps organized.

[ BUG ]

Describe

A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Download from the collection 1346
2. Wait until the error occurs from start

Error log (If present):

===Some Error===

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional information:

• Operating System: [e.g. iOS]

Additional context
Add any other context about the problem here.

[ Suggestion ] Download "ocdl-missing.log" missing files

• Make a new file to paste the file path or just a file to paste all the links. # Something like "missing-beatmaps-list.txt"
• Add an option in the terminal to check if the user wants to download the missing Beatmaps.
• Maybe making a folder exclusively to save the "ocdl-missing.log" with "Collection Name + Date and time" so it's easier to download and select the one you want to download.

Anyways, thanks for developing this amazing tool!

Collections with forward slashes in their names result in an ENOENT error

I'm on linux so I don't know if this error also occurs on windows.

Example Collection: https://osucollector.com/collections/1409

Terminal Output:

Please Enter An ID: 1409
node:fs:1349
  handleErrorFromBinding(ctx);
  ^

Error: ENOENT: no such file or directory, mkdir '/home/user/Downloads/linux-arm64/Streams/Death'
    at Object.mkdirSync (node:fs:1349:3)
    at mkdirSync (pkg/prelude/bootstrap.js:1642:33)
    at Main.run (/snapshot/osu-collector-dl/dist/core/Main.js:45:28)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async /snapshot/osu-collector-dl/dist/index.js:10:5 {
  errno: -2,
  syscall: 'mkdir',
  code: 'ENOENT',
  path: '/home/user/Downloads/linux-arm64/Streams/Death'
}

I imagine a potential solution to this would be checking for path separators and other illegal characters and replacing them with another character like an underscore.