GithubHelp home page GithubHelp logo

ropenspain / siane Goto Github PK

View Code? Open in Web Editor NEW
10.0 10.0 2.0 22.78 MB

R package to represent statistical data on official Spanish maps at several administrative levels

License: Other

R 100.00%
choropleth choropleth-map ign ine maps spain

siane's People

Contributors

cjgb avatar nuniemsis avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

siane's Issues

Code problems

From R CMD check --as-cran:

* checking package dependencies ... NOTE 
Depends: includes the non-default packages: 
  ‘RColorBrewer’ ‘classInt’ ‘maptools’ ‘plyr’ ‘raster’ ‘rgdal’ ‘sp’  
Adding so many packages to the search path is excessive and importing 
selectively is preferable.
* checking dependencies in R code ... NOTE
Packages in Depends field not imported from:
  ‘RColorBrewer’ ‘classInt’ ‘maptools’ ‘plyr’ ‘raster’ ‘sp’
  These packages need to be imported from (in the NAMESPACE file)
  for when this namespace is loaded but not attached.

These packages should be Imports, not Depends.

* checking R code for possible problems ... NOTE
brks_color: no visible global function definition for ‘classIntervals’
get_dir : <anonymous>: no visible global function definition for ‘tail’
siane_map: no visible global function definition for ‘bind’
siane_map: no visible global function definition for ‘shift’
siane_map: no visible global function definition for ‘as’
siane_map: no visible global function definition for ‘proj4string<-’
siane_merge: no visible global function definition for ‘join’
stop_advices: no visible binding for global variable ‘value’
Undefined global functions or variables:
  as bind classIntervals join proj4string<- shift tail value
Consider adding
  importFrom("methods", "as")
  importFrom("utils", "tail")
to your NAMESPACE file (and ensure that your DESCRIPTION Imports field
contains 'methods').

Documentation problems

From R CMD check --as-cran:

* checking Rd line widths ... NOTE
Rd file 'siane_map.Rd':
  \examples lines wider than 100 characters:
     shp <- siane_map(obj = obj, level = "Municipios", canarias = FALSE, peninsula = "close") # Loading the municipality's map of Spain

Rd file 'siane_merge.Rd':
  \examples lines wider than 100 characters:
     shp <- siane_map(obj = obj, level = "Municipios", canarias = FALSE) # Loading the municipality's map of Spain
     df <- as.data.frame(read.px("/home/ncarvalho/Downloads/2879.px"))# Get this file in INE's website. Check the README to learn how to do  ... [TRUNCATED]

These lines will be truncated in the PDF manual.

Please, place the comments over the line (and in multiple lines if a comment is longer than 100 characters).

Siane - rostemplate project

https://github.com/orgs/rOpenSpain/projects

Dear developers,

I have created a fork including the deploy of your package on your gh-pages branch using the rostemplate (see Slack channel and https://ropenspain.github.io/rostemplate/). See a live preview of your pkgdown site here:
https://dieghernan.github.io/Siane/

An additional GitHub Action check-standard.yaml has been included. That action would check your package (AS CRAN) on several platforms on every push, pull request and every first day of the month. The goal is to provide CI on your package.

Actions on your package:

  • Check locally and rebuild documentation (upgrade Roxygen version)

  • Fix a small typo on docs (extra '#)

  • Vignette: Fix mismatch on %\VignetteIndexEntry()

  • Implementation of github-actions and related .gitgnore and .Rbuildignore

Next steps

You should receive a Pull Request with these modifications.

After your review and in case you consider merging, consider to deploy Github Pages on your settings (gh-pages branch).

Once it is done, I would appreciate if you move this issue to the Deployed tab on the Project panel (see also Projects tab on this website).


LOG

@cjgb, @Nuniemsis

TODO: Open issue and pull request. Fina deploy up to the owners of the repo

Malformed DESCRIPTION

From R CMD check --as-cran:

* checking CRAN incoming feasibility ... NOTE

The Title field is just the package name: provide a real title.

The Title field should be a short description of the package.

* checking DESCRIPTION meta-information ... NOTE
Malformed Description field: should contain one or more complete sentences. 

Current Description should be in Title, and Description should provide a comprehensive description of the package.

License components which are templates and need '+ file LICENSE':
  MIT

Should be MIT + LICENSE file, and an appropriate LICENSE file should be present.

Author field differs from that derived from Authors@R
  Author:    ‘Carlos J. Gil Bellosta[aut, cre] Nuno Carvalho[aut]’
  Authors@R: ‘Carlos J. Gil Bellosta [aut, cre], Nuno Carvalho [aut]’

Maintainer field differs from that derived from Authors@R
  Maintainer: ‘Nuno Carvalho <[email protected]>’
  Authors@R:  ‘Carlos J. Gil Bellosta <[email protected]>’

If Authors@R is present, then Author and Maintainer are automatically derived from there, so both fields should be removed. Also there's a discrepancy: if you are the maintainer, you should be marked as [aut, cre], not Carlos.

Finally, packages cannot depend on a patch release. Depends: R (>= 3.3.1) should be Depends: R (>= 3.3.0) instead.

Error with readOGr

Follow your example I get an error

shp <- get_siane_map(obj = obj, level = level, year = year, canarias = canarias)
Error in ogrInfo(dsn = dsn, layer = layer, encoding = encoding, use_iconv = use_iconv,  : 
  Cannot open file

Top-level files problems

From R CMD check --as-cran:

* checking top-level files ... NOTE
Non-standard file/directory found at top level:
  ‘Images’

Please, create a .Rbuildignore file and add Images and README.md to it.

objeto 'final_dir' no encontrado

Dear Siane creators.

I've followed the steps in your webpage to plot my data on a Spain map (specifically I want to plot over Andalusia region). No problem installing the package, neither with the register_siane function, but whe I try to run the siane_map the following error appears. Any clue to resolve this problem will be welcome!

library(Siane)
obj <- register_siane("/home/angel/gitrepos/covid19/datasets/siane/")
shp <- siane_map(obj = obj, level = "Municipios", canarias = FALSE)

Using default year as the latest year 
Error in get_dir(base_path, dirs_path, last_path, year) : 
  objeto 'final_dir' no encontrado

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.