Comments (3)
@ipa-mdl , @ipa-fmw I have started with the refactor.
For that, I have started refactoring the state machines, what I consider the kernel of the 402 and therefore the most important part to work properly.
I took the decision to change the SMs to use the boost Meta State Machine (MSM), where I can get a better view of the actions and the guards and to use the transition table, where I and anyone else in the future could have a better view of what is really happening. And also have more reliability concerning the state transitions, the mode switching and all the internals. Please, see, for a general idea:
I am implementing the 402 SM and the sub-machines, as well as I want to implement a higher level SM (ON, OFF, etc...). It is not everything online,yet.
This should take quite some more time and effort, and in my opinion is a relevant change. If you have something against the approach, please inform me as soon as possible, so that I may concentrate the efforts on the other aspects.
Thanks.
from ros_canopen.
This sounds great, the 402 proflie is rather complicated and a clean state machine implementation would improve the robustness and maintenance.
I am a little bit concerned about the effort, but the benefits may be worth it.
from ros_canopen.
this is a critical issue for https://github.com/ipa320/ros_canopen/milestones/ROS-I%20release
@thiagodefreitas when do you think this will be finished as it is blocking us with the ROS-I release? Where can I find the modifications you already did? what is still missing?
from ros_canopen.
Related Issues (20)
- catkin_make failed
- Mode Switch timeout is too short for some drives HOT 1
- Can I transmit a rostopic detecting a pedestrian to a canframe. How do I do that using roscan open?
- Rostest canopen_master test fails occasionally
- I have encounterd errors when I use ros_canopen
- Unable to initialize driver: Supported drive modes (object 6502) is not valid HOT 7
- CAN Bridge Node can't differentiate between multiple interfaces after reception / before sending HOT 3
- I have encounterd errors when I use ros_canopen like below.
- Re-init error
- ROS2 can used this code? HOT 2
- Recovery from USB disconnection HOT 1
- Can device goes into an error state and the socketcan node never recovers HOT 1
- Canopen_master initializing failure with "std::bad_cast; Could not set transition" HOT 3
- Could not switch to mode 1, reason: Mode switch timed out. HOT 1
- Invoking "make -j12 -l12" failed HOT 1
- How to import the EDS files from servo motor manufacturers into the ros_canopen package? HOT 1
- CAN IDs of 0x18FFFFFF not showing up in candump
- [ERROR] internal error: 76 HOT 1
- Lagging, buffering and freezing behaviour in DS402 motor control with PDOs HOT 4
- Read CAN messages with ROS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ros_canopen.