Default exit handler always has return code of 0 on windows about launch

[mikaelarguedas]

Based on the comment

launch/launch/launch/exit_handler.py

Lines 41 to 42 in a1057c7

	# since Python < 3.5 on Windows does not support signaling SIGINT to the subprocesses
	# we can't expect them to shutdown cleanly, therefore we ignore their return code

It may be worth looking at the behavior with python 3.5+ (we're currently using 3.6.3 on the windows machines and require 3.5 for all our python code)

[dhood]

@sloretz I just stumbled upon this issue which doesn't have the bouncy milestone anymore but it doesn't seem like the milestone was ever intentionally removed (maybe a ui bug?). shall we put the bouncy milestone back manually, or did you actually remove it?

[sloretz]

@dhood I don't remember. It doesn't look like this issue was ever intentionally put into the bouncy milestone.

I just added and removed the milestone to see what the github UI says. It looks like the github ui says "added" when a milestone is added, and "cleared" when it's removed. However if those happen back-to-back it collapses them both into "modified". I think on Mar 1 I must have accidentally added this to the bouncy milestone, then cleared it and set labels instead.

[dhood]

ok thanks that makes sense 😄

[wjwwood]

Closing since the legacy launch testing is no longer in use.