Comments (2)
Renaming a class is probably not a good idea, especially when it is part of a library AND is a public API. This is because libraries are meant to be used in other projects, and if such a refactoring is done, it would unnecessarily introduce a breaking change and will require the implementations in dependant applications to be changed as well.
If that kind of refactoring is really needed, deprecating the current API and introducing a new API should be considered so other implementations have enough time to migrate to the new API. However, this might lead to significant changes in the library's codebase depending on how widely the current API is used internally in the library.
from sora-editor.
@itsaky You're right. Deprecating the current API would be a logical solution. Also, there are only about 16 to 17 usages in the library's codebase, which I think would be easy to replace right now rather than when the codebase expands.
I'm proposing this change since this library would be used in many projects and having a clear name would allow the developers to easily understand what the interface does as well as align with the naming conventions.
from sora-editor.
Related Issues (20)
- Crash due to editor : java.lang.IllegalArgumentException: Not a valid Unicode code point: 0x800002C6 HOT 1
- Language pack for popular languages
- Refactor the language-textmate module with Kotlin?
- Crash HOT 14
- Enhance Pressing Down Logic of Selection Handle
- [Refactor] Editor Cache and Fields in `ContentLine`
- [Feature] Implement shallow copy and thread-safe shared data in `Content`
- Crash when reuse CodeEditor and Content object HOT 1
- Crash when settingText with less lines than previous Text HOT 2
- Crash when search thread running HOT 3
- Support Live Templates HOT 5
- Application Crashed HOT 1
- Make line separator compatible with windows CRLF = LF HOT 1
- .c或.cpp文件注释的字体颜色 HOT 2
- App crashes after calling setEditorLanguage method HOT 3
- Language-Textmate Desugar not work HOT 5
- [bug]: cannot display unicode symbols
- Is any plan to add AI code assistant, I which will improve typeing productivity on mobile devices HOT 1
- [bug] word wrap spillover
- OutOfMemoryError exception when opening 365M file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sora-editor.