GithubHelp home page GithubHelp logo

rossbencina / queueworld Goto Github PK

View Code? Open in Web Editor NEW
83.0 83.0 12.0 244 KB

A light-weight C++ toolkit for building concurrent, lock-free, message-passing programs.

License: MIT License

C 0.84% C++ 99.16%

queueworld's Issues

Race condition in QwSpscUnorderedResultQueue::push()

QwSpscUnorderedResultQueue::push() currently uses the following algorithm:

void push(Node *node)
{
    Node *top =  atomicLifoTop_.load(std::memory_order_relaxed); // (*)
    node->next = top;
    atomicLifoTop_.store(node, std::memory_order_release);
}

The bug is that somewhere after (*) and prior to atomicLifoTop_.store(), the pop() function may execute:

node_ptr_type result = atomicLifoTop_.exchange(0, std::memory_order_acquire);

This would leave atomicLifoTop_->next pointing to a node that is no longer on the stack.

The fix is to use compare_exchange instead of store, to handle the above condition as a special case. (This fix will work because QwSpscUnorderedResultQueue is single-producer single-consumer, so it is not possible for other threads to interfere.)

void push(Node *node)
{
    Node *top =  atomicLifoTop_.load(std::memory_order_relaxed);
    node->next = top;

    if (atomicLifoTop_.compare_exchange_strong(top, node,
                /*success:*/ std::memory_order_release,
                /*failure:*/ std::memory_order_release) == false) { 
        assert(top == 0);
        node->next = 0;
        atomicLifoTop_.store(node, std::memory_order_relaxed);
    }
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.