roudikk / guia Goto Github PK

First of all, the library is amazing and it suits our use cases well. My current issue is I am getting this error when I update compose dependencies to 1.5, compiler to 1.4.5. the app is compiling successfully but it crashes saying:

java.lang.NoClassDefFoundError: Failed resolution of: Landroidx/compose/animation/AnimatedContentScope.
at com.roudikk.guia.containers.ScreenContainerKt$ScreenContainer$2.invoke(ScreenContainer.kt:25)
...
Caused by: java.lang.ClassNotFoundException: Didn't find class "androidx.compose.animation.AnimatedContentScope"

as they renamed AnimatedContentScope to AnimatedContentTransitionScope in 1.5.

Can we have an update for compose 1.5?

Hi

I have a problem with the bottomSheet.
Screen record from guia sample app:

Velocity of fling is not passed to children list.

I found the problem in this method:

        override suspend fun onPreFling(available: Velocity): Velocity {
            val toFling = Offset(available.x, available.y).toFloat()
            return if (toFling < 0 && offset.value > Float.NEGATIVE_INFINITY) {
                performFling(velocity = toFling)
                // since we go to the anchor with tween settling, consume all for the best UX
                available
            } else {
                Velocity.Zero
            }
        }

If you replace it with this, it will work, but I don't know side effects:

        override suspend fun onPreFling(available: Velocity): Velocity {
            return Velocity.Zero
        }

I'd like to be able to provide navigation generically from feature modules.

The app module could gather all provided navigation via dagger multibindings.

Perhaps something like this: