GithubHelp home page GithubHelp logo

Comments (7)

EmmanuelMess avatar EmmanuelMess commented on June 11, 2024

Solved in #6?

from swipeselector.

roughike avatar roughike commented on June 11, 2024

@EmmanuelMess

Solved in #6?

Nope, that only solves it for the sample app, not for the SwipeSelector View itself. And that wouldn't be a solution, rather a hack. See this Stack Overflow answer.

The API level 8 support commit was looking fine though. It was coming, but I was too busy with other projects (in other words: lazy) to get it done before you.

I'll merge it when I've tested it and learned to merge just that part. Don't hold your breath because I'm such a noob with git.

from swipeselector.

EmmanuelMess avatar EmmanuelMess commented on June 11, 2024

@roughike
So, when the activity restarts the state shouldn't? I don't quite understand when the state should be saved and isn't.

from swipeselector.

roughike avatar roughike commented on June 11, 2024

@EmmanuelMess
Whenever an Activity is being stopped, all of its' Views get notified by a callback the Activity calls and they can return a Parcelable with the saved state. Then, when the Activity restarts, all the Views are passed the same Parcelable that they previously returned.

So it's like a container that you can drop stuff into and then get it back so you remember where you left off.

I haven't fixed this just yet, but it should be relatively simple. Will probably fix in the next version when I have some free time.

from swipeselector.

EmmanuelMess avatar EmmanuelMess commented on June 11, 2024

@roughike Solved at Solved state holding issue but I don't want to cluster too many things and have to close and open another pull request ;); Sorry if I'm bothering you you too much, I still want to help... also .."take any feedback you’ve received and go forth and pull request again"...

from swipeselector.

roughike avatar roughike commented on June 11, 2024

@EmmanuelMess
Well thank you! They're looking good. I'll merge these when I have the time to test them.

from swipeselector.

roughike avatar roughike commented on June 11, 2024

Aaaaaaand done. Now we're perfect.

Huge thanks to @EmmanuelMess for helping to close this issue. My lazy ass probably wouldn't have fixed this until next year.

from swipeselector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.