rounak / rjimageloader Goto Github PK

View Code? Open in Web Editor NEW

833.0 833.0 89.0 361 KB

A recreation of the image loader animation created by Michael Villar for iOS

License: MIT License

Ruby 1.66% C 1.12% Objective-C 93.07% Shell 4.15%

rjimageloader's People

Contributors

Stargazers

Watchers

Forkers

bguidolim andrewgubanov luiseduardohdbackup carabina creantan themrugraj germc augmify engmsaleh zhmios jbttn gabemdev vfa-thinhhq matrixy aaaliua ahmedalmoraly hydra2050 zgilbert kelvinlaw637 edison9888 pengxianhe heliang219 9191app ilyi1116 hanhailong kerasking sdgandhi qq514581077 joblh crazeyguy aipoyun seishin kartel mixlan123 olafli frostfeng mohsinalimat autox heluxsh ljssafe hejunbinlan shidiansoftware wangjianxue lc0524 andy-jiangbin xiaojiaxi gudjao obornjung suchitabohra shangjin-li hyuni chengxxxxwang rajaseenivasan8989 raybon-lee ironman-i dorallee brickleberry corolala jeffasd acetee jxzy999 learnwithgabbar hersonx carloskekwa weicx zhuzhengwei yeahdongcn applejian 583175259 yufeiskyer k214k darren-xd llsource kb100824 bablu-joshi mycout fadeve hxicoder sumlunmao childdivin kdxdaxiong628 peteralen myiosemail rickychez sohamiyer10 chimouajain

rjimageloader's Issues

Image flicker

After the reveal animation is done, there is a quick flicker. Is there a way to remove this flicker?

Custom Image from local rep

How load custom image from my local rep. with animation

Bugs

pod try RJImageLoader opens broken project.
trying out pod in app, animation runs once, then on second run it is inversed and finally after that it's completely gone.

I made a small video: http://cl.ly/1y0G1p050o0M. I think the problem is in SDWebImage:

    self.photoImageView.image = nil;

    [self.photoImageView startLoaderWithTintColor:[UIColor blueColor]];
    NSLog(@"Start loader");

    __weak typeof(self) weakSelf = self;
    [self.photoImageView sd_setImageWithURL:url
                           placeholderImage:nil
                                    options:SDWebImageRetryFailed | SDWebImageRefreshCached
                                   progress:^(NSInteger receivedSize, NSInteger expectedSize) {
                                       dispatch_async(dispatch_get_main_queue(), ^{
                                           CGFloat percent = (CGFloat)receivedSize / expectedSize;
                                           [weakSelf.photoImageView updateImageDownloadProgress:percent];
                                           NSLog(@"Update progress = %f", percent);
                                       });
                                   }
                                  completed:^(UIImage *image, NSError *error, SDImageCacheType cacheType, NSURL *imageURL) {
                                    [weakSelf.photoImageView reveal];
                                    NSLog(@"Reveal loader");
                                  }];

I posted couple of issues in SDWebImage related to this problem. SDWebImage/SDWebImage#1090

Since SDWebImage is a wreck, we can avoid completion handler and run all animations in progress block:

    self.photoImageView.image = nil;

    [self.photoImageView startLoaderWithTintColor:[UIColor blueColor]];
    NSLog(@"Start loader");

    __weak typeof(self) weakSelf = self;
    [self.photoImageView sd_setImageWithURL:url
                           placeholderImage:nil
                                    options:SDWebImageRetryFailed | SDWebImageRefreshCached
                                   progress:^(NSInteger receivedSize, NSInteger expectedSize) {
                                       dispatch_async(dispatch_get_main_queue(), ^{
                                           CGFloat percent = (CGFloat)receivedSize / expectedSize;
                                           [weakSelf.photoImageView updateImageDownloadProgress:percent];
                                           NSLog(@"Update progress = %f", percent);

                                           if(receivedSize == expectedSize) {
                                               [weakSelf.photoImageView reveal];
                                           }
                                       });
                                   }
                                  completed:^(UIImage *image, NSError *error, SDImageCacheType cacheType, NSURL *imageURL) {
                                  }];

But then it's all broken after I run it twice, see video: http://cl.ly/2U192i321D1N

every time loading in tableview cell?

Hi I am working with the RJImage Loader using podfile.working fine. I am using in Tableview Cell for image loading but when i scroll then every time it is showing loader and tableview not moving smoothly
below code i am using in cellForRowAtIndexPath

_imageview =cell.mediaImageView;
[_imageview startLoaderWithTintColor:[UIColor redColor]];
// [self indicatore];
__weak typeof(self)weakSelf = self;
urlString = messageString;
[weakSelf.imageview sd_setImageWithURL:[NSURL URLWithString:urlString] placeholderImage:nil options:SDWebImageRetryFailed | SDWebImageRefreshCached progress:^(NSInteger receivedSize, NSInteger expectedSize) {
[weakSelf.imageview updateImageDownloadProgress:(CGFloat)receivedSize/expectedSize];
} completed:^(UIImage image, NSError error, SDImageCacheType cacheType, NSURL *imageURL) {
[weakSelf.imageview reveal];
}];

where i am missing please help me

rounak / rjimageloader Goto Github PK

rjimageloader's People

Contributors

Stargazers

Watchers

Forkers

rjimageloader's Issues

Image flicker

Custom Image from local rep

Bugs

every time loading in tableview cell?

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Jobs