roysmith / spi-tools Goto Github PK

See https://en.wikipedia.org/wiki/Wikipedia:Sockpuppet_investigations/Vallabhas/Archive. There's two three (distinct) 12 April 2020 entries. We need to be able to handle this correctly.

https://spi-tools-dev.toolforge.org/spi/timecard/Jaktheladz?users=Fish%26Chimps

The & should probably not be escaped in the javascript?

<canvas id="chart-Fish&amp;Chimps" width="300" height="150"></canvas>

var ctx = $(document)[0].getElementById('chart-Fish&Chimps').getContext('2d');

Right now, we read it in ~/.bash_profile. That should happen in app.py, just like all the other django environment.

We've got test_*.py and *_test.py styles. We should use the same style for all of them.

Points to consider: some tests need to run under manage.py because they depend on django configuration. But, raw unittest is faster. Maybe we need a convention to say which tests need django?

[[Batman: The Dark Knight (roller coaster)]] is in main space!

This is causing bad alignment in sock-select.dtl:

label {
    margin-bottom: .5rem;
}

Some combination of "most recent N events" and "specified date span"

Consider https://pypi.org/project/watchdog/

Imagine we ask for:

count = 10
main=False
draft=True
others=False

on a user with 1 million edits but none to draft space. We'll iterate through all 1 million edits trying to find 10 drafts. There should be some circuit breaker which cuts the search off before then. Maybe never examine more than 10*count?

• Make sure file rotation is really happening
• Add timestamps to log files
• Consider running my own private syslog instance

ArchiveError at /spi/ip-analysis/Bideliran/
Multiple sockmaster names found: {'Bidelirania', 'Bideliran'}

Not sure what we should do there, but at least not crash.

Sometimes [[Wikipedia:Sockpuppet investigations/Cases/Overview]] is out of sync (due to caching?), or you just want to work with an archived case.

This could also be used as a "combine result from two different cases" scenario (#27).

Indicate whether sock is blocked, add links to user page, contributions, etc

Click on the "Case (sockmaster) name" popup. Clear the default entry, type the name of a different case, and accept. You get a "This field is required" error.

See https://www.mediawiki.org/wiki/Requests_for_comment/Content-Security-Policy

Javascript and CSS should be downloaded and served locally as static files.

On occasion, the archive page isn't where you expect it to be. On even more rare occasions, there might be more than one archive. We should handle these correctly.

From https://tools.wmflabs.org/spi-tools-dev/spi/ip-analysis/Marcolacson/

Request Method: | GET
https://tools.wmflabs.org/spi-tools-dev/spi/ip-analysis/Marcolacson/19%20December%202019

shortcuts.redirect()

"A view name, possibly with arguments: reverse() will be used to reverse-resolve the name"

Consider https://drvic10k.github.io/bootstrap-sortable/index.html

https://tools.wmflabs.org/spi-tools-dev/spi/spi-sock-select/Alex%20Neman/?archive=1

Expected exactly 1 level-3 heading, found 6

Either finish tearing out the rest of the selectize support in spi.forms.CaseNameForm, or make selectize work again (see af32e87). If we keep the support, spi.forms.SelectizeField certainly needs to be refactored to not do mwclient API calls inside a form.

In IndexView:

jquery.slim.min.js:2 jQuery.Deferred exception: $(...).selectize is not a function TypeError: $(...).selectize is not a function
at HTMLDocument. (https://spi-tools-dev.toolforge.org/spi/:231:24)
at l (https://tools-static.wmflabs.org/cdnjs/ajax/libs/jquery/3.3.1/jquery.slim.min.js:2:29567)
at c (https://tools-static.wmflabs.org/cdnjs/ajax/libs/jquery/3.3.1/jquery.slim.min.js:2:29869) undefined

Include that in the log file, and on the debug data card.

See https://github.com/jaddison/django-cachebuster

Consider using {% static %} tag.

(index):133 Uncaught ReferenceError: $ is not defined
at (index):133
(anonymous) @ (index):133

Related: https://phabricator.wikimedia.org/T256482