rpazyaquian / flask-heroku Goto Github PK

One drawback of how I approach the embed.js snippets is that every time a page is rendered, it creates a new embed.js file for reference. I can't help but think that this will become a problem in the future. What should I do to avoid this? Is there a way to add pure JS to the webpage to render the plot, or does that not make sense?

"Small mini projects you could add:

Let me plot multiple stocks.
Let me mark stocks as favourites, and have the site remember them.
Let me keep the browser window open and have the chart update throughout the day.
Send me email when one of my favourite stocks hits a threshold."

1 should be doable, I just don't know how (yet).
4, I think I can do too. I'll need a user-email database for that, though.

2 and 3 are more complicated because the way it's structured right now doesn't really support doing that. Those are dependent not on rendering HTML but on working with the Javascript backbone, which isn't as well documented as the main module.

Theoretically, I should just be able to call build_plot() on a list of stock symbols, and have it return an array of snippets associated with each plot. Each snippet in this array can then be rendered on the template.

However, I don't know how to get this to play well with the GET method. Would it be something like "/stocks?symbols=AAPL,GOOG,IBM,NTDOY"?

"You should consider breaking your website out into several different files. You can put the CSS and Javascript within your 'static' folder and then simply reference them from your main template or whatever. As it is right now it looks like you copied the contents of all .js and .css files into your template.

You may want to look into using something like JSON to shuttle information from your app to your webpage. Currently you have "hard-coded" (I know you compute it and then plug it into your template) the data as a variable in your javascript. Basically you'd have http://rpazyaquian.herokuapp.com/st...ata?symbol=MSFT return some JSON based upon your backend calculations and then a javascript callback would update the plot.

Some plot labels would be nice so I know what I'm looking at.

Also, is there ever a situation in which you'd have more than one plot?"

For the stock charts as they are right now, I can't seem to get a CSS/JS relative path going. What I have to do right now is create an HTML page, and then move that page to /templates so that Flask can render them. Moving them breaks the plots if CSS and JS paths are set to relative, so for now they're inline. There has to be a simple way to work around this but I don't know how.

Like I mentioned before, I'm not familiar with BokehJS, the JS backbone. I've only ever used Bokeh as a Python module. I can look into the code to see how the data works - I think it DOES use JSON - but that may all be handled elsewhere and I suspect that this is ultimately up to the Bokeh devs, which I'm not a part of.

As for the plot labels and multiple plots, you should be able to do so by outputting several JS snippets at a time. What I can do in that case is iterate over them and put them in the template. Right now, though, I just have the website set to rendering a static HTML page.

"The zoom function does not work on recent versions of Firefox.

Consider adding mouse-over annotations or a data-table."

The problem with this is that I'm not super involved with Bokeh/BokehJs development, and I don't have Javascript experience, so I don't know what to do about this issue. I'll get back to this once I get the new version of the website up and running.

If the URL is pointed to a stock symbol that does not exist, e.g. http://rpazyaquian.herokuapp.com/stocks/argleblargle , the page returns a 500 error. This needs to be changed so that a proper error page shows up, or the routing should properly handle an invalid symbol.

I want to have the URL for accessing a certain stock symbol to instead be something like '/stocks?symbol=GOOG' as opposed to '/stocks/GOOG/. I don't know how right now, though.