rpherbig / dr-scripts Goto Github PK

Make stance syntax (in the setup file) flexible enough that I could say "Weapon" => ["shield"] and it would determine the second defensive skill dynamically

Convert the optional parameter to as few coins as possible (e.g. ;sell-loot 10 would withdraw 1 gold, not 10 silver)

https://elanthipedia.play.net/mediawiki/index.php/Appraisal#Creature_appraisal

https://elanthipedia.play.net/mediawiki/index.php/Appraisal#Creature

The relevant log:

[pick: disarm(casket, normal)]
[pick]>disarm my casket normal
You begin work at disarming the casket.
You work with the trap for a while but are unable to make any progress.
You get the distinct feeling your manipulation caused something to shift inside the trap mechanism. This is not likely to be a good thing.
Roundtime: 9 sec.

[pick: disarm(casket, careful)]
[pick]>disarm my casket careful

You carefully work at disarming the casket.
You work with the trap for a while but are unable to make any progress.
Roundtime: 12 sec.

[pick]>disarm my casket analyze
You've already analyzed this trap in preparation for harvesting, there's no need to do so again.

[pick]>disarm my casket harvest
The remnants of this casket's previous trap have already been completely harvested.

[pick]>disarm my casket analyze
You've already analyzed this trap in preparation for harvesting, there's no need to do so again.

[pick]>disarm my casket harvest
The remnants of this casket's previous trap have already been completely harvested.

[pick]>pick my casket ident
The lock is a trivially constructed piece of junk barely worth your time.
However, a misshaped pine casket is not fully disarmed, making any chance of picking it unlikely.
Roundtime: 5 sec.

[pick]>pick my casket quick
You deftly remove a lockpick from the lockpick ring and begin to work at quickly picking open the casket.
You realize very quickly that this was a very bad idea...
You attempt to pull the annoying grinning face from the casket and clumsily shred the fatty bladder behind it in the process.

A black cloud of ash and soot explodes out of the bladder on the pine casket, and you suddenly feel horribly transformed.
You realize that despite this mishap, the casket still has more to torment you with.
You return your lockpick to the lockpick ring.
Roundtime: 6 sec.

See sell-loot for an example of this behavior.

When selling a bundle, a pelt is removed and dropped so that the bundle can be reformed after selling.

We need to know the name of a container so the pelt can be put in there. Stow won't work, as it would just return the pelt to the bundle.

study tool
You study your toolstrap and think you could potentially PUSH, PULL, FIX, TIE (item) to toolstrap, UNTIE (item) from toolstrap, SHEATHE, and REPAIR in case it gets messed up somehow.
Your toolstrap will accept a total of 1 items. You think you can tie the following items: bow.
Your toolstrap currently has 1 item tied to it. You may LOOK ON toolstrap to see it.

untie bow
You remove a Nisha short bow from your burnished toolstrap.

tie bow to toolstrap
You attach a Nisha short bow to your burnished toolstrap.

see above.

When bleeding is detected, turn on the tendme script then retreat to a set saferoom.

Experiment with the ordering of retreat, tendme, retreat, walk_to due to roundtime.

Similar to what is done for wielding.

Relevant text to watch for:
"Remove what", "You sling", "You remove", "You aren't wearing that"

use tdp and tdp project to determine if you can even train, if so get enough money. (one training is 6 copper per starting stat. 21->22 = 126 copper.)

The charged maneuver for the Offhand Weapon skill requires weapons in both hands. However, as currently written the script would attempt to train Offhand Weapon with an empty right hand.

See #1 .

Some weapons are better than others for parrying, and parrying is partially based on weapon skill, so it's entirely possible that you want to dance with a weapon you are not training (e.g. when backtraining). However, dancing doesn't work if you have it set to a weapon you aren't training.

This is because the script can't translate dance skill into a weapon. If we define dancing in terms of a weapon, we don't have to take that step.

https://elanthipedia.play.net/mediawiki/index.php/Snipe

This ability is restricted to Survival-prime guilds (Ranger, Thief and Necromancer) of at least 40th circle.

@rcuhljr Can you elaborate on what this TODO means? My barbarian doesn't cast spells...

@rcuhljr - your comment in IRC suggested that this pattern was used in multiple places, but I can only find one occurrence in crossing-training (in method event_loop). Feel free to update the labels if you find more.

For example, combat-trainer's setup method could then use the wait_for_script_to_complete when starting combat-trainer-setup.

see title

Clean zills if necessary when performing

Relevant text:
``"The room is too cluttered to find anything here!"`

Provide warnings on encumbered status.

Relevant text to capture:

"You struggle, but find yourself lacking the inner fire to enact such a rage!"

form python
You feel your inner fire cool as you finish practicing the Form of the Python.

berserk avalanche
The ever-building avalanche of rage within you crashes to a sudden halt!

berserk earthquake
An aftershock of rage shudders through you one last time, before your fury crashes to a sudden halt!

Not all the fillers are needed due to spell preps and other actions, watch for the ready message.

consider replacing filler actions with analyze for more tactics training?

Keep killing till nothing is lodged in the room.

when all combat skills are 0/34 offhand is selected before a skill that trains using a main hand weapon resulting in its combat maneuver failing

We do have "play " and "stop play" bookending a few of the training methods, but sometimes that isn't enough to mindlock Performance before hitting the "skills capped" logic and pausing (or exiting).

Keep the play/stop logic that we have, but the script also needs to be able to train Performance itself.

How do we detect an invasion?

What do we do if one is detected? Log out if health below 50%?

Don't start looting until you've been in a room for 10-15 seconds to make sure it doesn't grab stuff while traveling or if you hunt a mob that's wandered into someones kill spot.

How should it be changed? Split into two methods?

Skin only for skill, not loot

In this case, I had no boxes and Locksmithing was my lowest skill. The script repeatedly tried to train Locksmithing by calling pick but my Locksmithing did not increase since I had no boxes; so it remained the lowest skill and was then chosen to train again.

Perhaps we need to add a cooldown to Locksmithing?

Track cooldowns in a local var, not UserVars.exp_timers. This localizes their management as well as simplifying the setup file.

I need a way to turn off specific maneuvers, like powershot for bows.

I'm not sure how my bastard sword ended up on the ground, but it did...

Relevant text:
You find it difficult to wield the sword, as it is lying at your feet!

You must rest a bit longer before attempting that maneuver again.

CombatVars.worn_weapons should be deleted in favor of CombatVars.worn_items. This may require adding a new property/attribute to CombatVars.worn_items, I'm not sure yet.

Only if UserVars.stop_on_mindlock is true, of course.

We're leaving exp on the table by continuing to disarm/pick while mindlocked.

If you run common first (or have it autostart) then combat-trainer will run.

Output from a clean Lich run:

;combat-trainer
--- Lich: combat-trainer active.
--- Lich: error: uninitialized constant Scripting::SetupProcess::DRC
combat-trainer:20:in <class:SetupProcess>' combat-trainer:19:inscript'
--- Lich: combat-trainer has exited.

"TODO: Hold something in hands during Mechanical Lore training if above a certain rank."

Hold something in hands during Athletics training if above a certain rank.

@rcuhljr - do you make use of the exit-on-skills-capped logic in crossing-training?

If not, I'd like to change it to not-exit and instead pause 30. If you do, then a UserVar to determine which action to take should work.

Specifically, I'm interested in selling bars and nuggets.

The rummage action has a /M option:

M = Raw Materials (stone, metal ore, bone, skins, wood)

@rcuhljr suggests using the following code to avoid mistaking bar for bark:

ordinals.each do |ordinal|
        while /you get/i =~ bput("get #{ordinal} bar from my #{UserVars.main_container}", 'what were you referring', 'you get')
                if checkright == "bar"
                    fput("sell bar")
                else
                    fput("put bar in my #{UserVars.main_container}")
                    break
                end
            end
        end

Add a safety net 60 second timer to spell casting.

Handles unknown cases where spell casting fails undetected. (backfires?)

Capture "check balance" output and echo it after returning to the safe room (so it is more visible)