GithubHelp home page GithubHelp logo

Comments (3)

rrazgriz avatar rrazgriz commented on August 23, 2024 1

I've published a new release (1.1.3) that appears to have triggered a OpenUPM build successfully.

from rats.

rrazgriz avatar rrazgriz commented on August 23, 2024

This was a bit confusing, I had to do some digging to understand how OpenUPM works. The 1.1.2 tag is on the correct commit in this GitHub repo. From my understanding OpenUPM only builds a release for a version once, when it sees a tag for the first time - so the tag is associated with the wrong commit on the OpenUPM side. Unfortunately, I can't take responsibility for the behavior of an external service when it's not in my purview.

In this repo, releases are ground truth for (relatively) stable versions, and tags are secondary to that - used to indicate a release. I target VCC and Standalone package builds using GitHub actions, so I can't guarantee compatibility with OpenUPM's package build system.

It's a bit strange to be presented with a service that builds independently on top of this software, and then be expected to support its as an additional release channel, with additional requirements and considerations. Given this, I'm going to mark this issue as wontfix, but I'll try to be mindful of this behavior when adding tags to commits in this repo. Please note that this does not mean I'm guaranteeing OpenUPM compatibility.

com.needle.editorpatching is a cool package, but I won't be adding an OpenUPM dependency. Harmony distribution is already complex enough with other packages including the plugin piecemeal.

from rats.

TayouVR avatar TayouVR commented on August 23, 2024

It's a bit strange to be presented with a service that builds independently on top of this software, and then be expected to support its as an additional release channel, with additional requirements and considerations. Given this, I'm going to mark this issue as wontfix, but I'll try to be mindful of this behavior when adding tags to commits in this repo. Please note that this does not mean I'm guaranteeing OpenUPM compatibility.

I did note that I'm aware you don't officially distribute to OpenUPM, I was just hoping you could tag another release and bump the version so the bugfix after the 1.1.2 tag can be available there.

I also understand you don't want to add the dependency, I didn't expect you too, just wanted to throw it in the room.

but I'll try to be mindful of this behavior when adding tags to commits in this repo.

thank you!

VRCFury currently uses a action to automatically bump version number and add a tag. Maybe something like that could help to make releases and versioning more stable and automated. But at that point, thats another whole can of worms x3

from rats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.