rrazgriz / rats Goto Github PK

If the top level of a layer only has sub state machines in it, it shows up as empty (the E next to the layer).

Not a huge deal, but thought I'd point it out.

I am looking to change refence path for many animations. When multi-selecting the animations it only does the first blend shape keys reference path but not for other animations.

Animator layers that do not contain any states are considered WD Off by the visual WD indicator below the animator graph (that states the WD for the entire controller).

Thus, even if all states in a controller are WD On, if there is an empty layer such as the common case of default Base Layers at the top, the controller will be considered Mixed by this visual indicator.

Causes states to disappear when moving them. We should handle this more gracefully.

Here's the same image as the readme has for comparison. Installed Harmony and RATS via VCC.

UdonSharp contains the 0harmony.dll in its folder by default Assets/UdonSharp/Runtime/Plugins/0Harmony.dll.

While I do think this is bad practice as it is a shared library, the readme / documentation could reflect this as it will break projects when importing your harmony package on top of it.

Edit: Reported to U#, as this is more of an issue on their side. See here

This can cause issues with other scripts that generate states with AddState. Let's patch internal functions so this doesn't happen. Thanks @Dreadrith for the help pointing this out and some direction in correcting it.

To copy and paste transition settings would be super nice!

in 1.1.2 there was a bug and you just pushed something right after in another commit without bumping version and tagging. The last git tag sits on the commit before the fix still, which breaks things like OpenUPM packaging
I understand, that the primary distribution of RATS goes through the VCC, or as download from releases, but I would really like OpenUPM to have the latest changes too, currently i have to stay on 1.1.1 in order to avoid the script compilation errors.

PS:
in the long term, it would also be cool if RATS had com.needle.editorpatching as dependency, so that installing harmony through (Open)UPM is automatic. I have no idea if that would interfere with the VCC though, probably not, but i can't expect you to add a dependency for this niche usecase.

The Animation icon overlaps if the Motion name is too short. It could use some minimum additional padding.

If Has Exit Time is unchecked, clicking on any transition will show a double or triple error on both existing, properly working transitions, and on newly created states and transitions.

Just checking off the box for Has Exit Time fixes this.

It's possible to pop out the parameter window, and this breaks certain things. Ex. when deleting a parameter:

Thanks to @JeTeeS for reporting this.

Blendtrees made in the animator cannot be utilized outside the source animator unless copy pasted. That's painful because changes will not propagate. An option to export the selected blendtree as a standalone asset would be very nice.

Asset Blendtrees available in the right click create menu might also be appreciated.

Some code @rurre assembled for specifically that a bit ago:

//Original from VRCAvatars3Tools by gatosyocora
//Simplified for just Blend Trees by Pumkin

using System.IO;
using UnityEditor;
using UnityEditor.Animations;

namespace CreateBlendTree
{
    public class CreateBlendTree : Editor
    {
        [MenuItem("Assets/Create/BlendTree", priority = 411)]
        private static void CreateNewBlendTree()
        {
            var folder = Selection.activeObject;
            var folderPath = AssetDatabase.GetAssetPath(folder);
            var assetPath = AssetDatabase.GenerateUniqueAssetPath(Path.Combine(folderPath, "BlendTree.asset"));

            var asset = new BlendTree
            {
                name = Path.GetFileNameWithoutExtension(assetPath)
            };
            AssetDatabase.CreateAsset(asset, assetPath);
            AssetDatabase.SaveAssets();
            AssetDatabase.Refresh();

            Selection.activeObject = asset;
        }
    }
}

Currently the custom node style is slightly larger than the default style meaning the nodes don't look properly snapped when using grid snapping.
Comparisons:

Default	Custom

I tried modifying the PSD myself, but I think gimp is not having a great time there, and i don't have or want to use photoshop.

I do generally prefer the flat style of the custom nodes, but them being too big triggers my OCD.. >.<

Causes errors when RATS also tried to load Harmony.

The UI breaks when in Android (Quest) build mode.

Not sure if it is related but I saw the following warning in the console:
[RATS v1.1.2] 0Harmony.dll not found - Patches Skipped!

Image of the issue:

I have both 4.7.1 and 4.7.2 frameworks installed.

I tried setting everything to 4.7.2 in the .csproj files which worked for a single session with no errors (however maybe other things weren't functioning as they should?) but after a restart of Unity or VSCode, it reset everything to 4.7.1.

The default transitions settings set in the RATS Options window only apply to regular animator state transitions and not Any State transitions.

PatchBreakUndoSubStateMachinePaste breaks the layer view and throws null exceptions when trying to undo following a paste in 2021.3.22f1, but not 2019.4.31f1. May be good to define this out when in 2021+.

Its maybe not a very common thing to do, but I sometimes end up refactoring some thing on my avatar and need to convert some parameter from a float to int, or the other way around, (e.g. to use it in blendtrees).
Currently I go in the file and find the parameter there using n++ and change the type enum number manually. I think this would be in the scope of this, if i encounter it more I might PR it myself too.