Comments (4)
Can someone that has access to the specification check if VIF=0x7B is allowed?
According to https://m-bus.com/documentation-wired/08-appendix, I cannot se anything that indicates it.
Or are we off when decoding the data?
sen_pollutherm.hex after some re-formating
68 42 42 68 08 08
72 76 00 05 21 18 4E 31 04 51 00 00 00
0C 07 64 08 00 00
0C 14 92 98 79 00
0C 7B 02 03 00 00 # <==
0C 2C 58 54 00 00
0A 5A 55 07 0A 5E 94 05 0B 60 76 60 01 0C 78 76 00 05 21 0C FD 10 76 00 05 21 1F B3 16
from libmbus.
I prefer to fix the decoding issue instead of disabling the complete XML output.
from libmbus.
I prefer to fix the decoding issue instead of disabling the complete XML output.
@lategoodbye : Yes, fixing a decoding error is something we ALSO should do, but according to me, that is a separate issue.
The suggested update in #170, 7297899, follows the rule "fail early, fail hard" to make sure that problems are noticed and not ignored.
This change will make a whole class of potential problems detectable when running tests.
from libmbus.
I've a different opinion about this. There will always a byte the libmbus cannot decode and the public available document won't save us everytime. From a unit test point of view the suggested "fail early, fail hard" is good, but from end user perspective i'm concerned that this could be seen as a regression and the users tend to use older versions.
So i prefer to keep the best effort XML output in error case, but make mbus_parse_hex fail with an error code.
from libmbus.
Related Issues (20)
- ./build.sh Failure HOT 1
- m.bus Adapter - Current Unrecognized VIF extension: 0x3a - Stromzähler B+G Tech SDM 630 V2 HOT 4
- Cannot find or read devices because of timeouts HOT 5
- Mbus clarification HOT 3
- Finding EMU meters via mbus-tcp-scan-secondary
- Value resolution
- Negative values start with F HOT 4
- rs485 to usb converter and libmbus?
- Documentation not accesible HOT 2
- Decoding frame data
- Add manufactorer specific VIFE infos in (XML) response
- Feature Request: Eastron-SDM-Serie: instantaneous electrical information HOT 5
- Sending different init frames to a slave... HOT 2
- I'm trying to get data from mbus tc, it doesn't find any results when I scan
- Received invalid M-Bus response frame HOT 1
- IPv6 does not work HOT 4
- Pollucom E- reduced / unexpected answer?
- IME Electrical meter support HOT 2
- libmbus problem in python-script HOT 2
- Debian packaging fork HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libmbus.