GithubHelp home page GithubHelp logo

Comments (5)

rsjaffe avatar rsjaffe commented on May 22, 2024

Please try assigning temperature to one of the other sliders to see if the problem is related to that slider or not. Thanks.

from midi2lr.

neilpho avatar neilpho commented on May 22, 2024

Good idea. I tried another slider and a knob and the problem is related to temperature rather than the control used.

from midi2lr.

rsjaffe avatar rsjaffe commented on May 22, 2024

Hmm. Could you try the following?

In the plugin's directory, open up the file MIDI2LR_Client.lua in a plain text editor like notepad. Around 30 lines down, you'll find the following code:

local function midi_lerp_to_develop(param, midi_value)
    -- map midi range to develop parameter range
    local min,max = LrDevelopController.getRange(param)
    if(param == 'Temperature' and max > 8000) then
        min = 2000
        max = 8000
    end

    local result = midi_value/127 * (max-min) + min
    return result
end

Edit the line

if(param == 'Temperature' and max > 8000) then

to read

if(param == 'Temperature') then

Save the modified file, then, in lightroom, open up the plug-in manager (file->plugin manager), select the MIDI2LR plugin and press the button to reload the plugin. Or you could just restart LR. Then see if that fixed the issue.

If that didn't fix the issue, edit the lua file to remove the range control for temperature by deleting the following lines, then test as above.

    if(param == 'Temperature' and max > 8000) then
        min = 2000
        max = 8000
    end

from midi2lr.

Der-Canonier avatar Der-Canonier commented on May 22, 2024

The error occurs with me also. Both solutions are not working. The temperature will be provided by 5250 to 4409 and then to 3559, then nothing happens. Increasing the temperature does not work

from midi2lr.

rsjaffe avatar rsjaffe commented on May 22, 2024

I'm reverting the change that was made to the temperature range control. Will see this change in the next release.

Reverted commit 31c029c in commit d24f025 .

from midi2lr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.