rsvensson / gamecollectionmanager Goto Github PK

Summary
If the user uses the Randomizer tab to randomize a game, then goes back to a table tab and opens either the details side-panel or the filter panel, the window expands outside the bounds of the screen if it is fullscreen.

This is caused by the cover image that gets displayed in the randomizer tab, since getting a game without a cover in the randomizer does not produce the same issue.

Expected result
The randomizer showing a cover image shouldn't interfere with the rest of the application.

Repro steps
0. Have some games with cover images in the collection.

1. Go to the Randomizer tab and select platforms to randomize from.
2. Click randomize until you get a game with a cover image.
3. Go back to for example the Games tab.
4. Open either the details side-panel or the filter panel.

Summary
Opening both the side-panel and the filter panel at the same time can cause them to misbehave and push each other's widgets up/down in an attempt to fit everything. This only makes widgets overlap, and even go outside the screen dimensions. It seems to mostly be the side-panel that pushes the filter panel down, while also having its widgets overlap the cover image a bit etc.
This only applies when the screen size is smaller than the contents of the panels. So it happens consistently on my old laptop's 1280x800 screen but not at all on a 1920x1080 screen.

Expected result
Ideally the filter panel should have priority over the side-panel, and draw over the contents of the side-panel without shrinking it.

Repro steps
0. Set a lower screen resolution.

1. Go into one of the table tabs, such as the one for Games.
2. Double click an entry to open the side panel.
3. Now click on the Filter button on the bottom right to open the filter panel.
4. Notice how the filter panel contents can't fit on the screen, and the side-panel contents overlap the cover image, while both panels are opened.

Notes
Screen shot has been attached. In the screenshot, the side panel's labels are overlapping the cover image, and the search bar under the filter panel is not visible.

Summary
Occasionally when fetchinfo.py's getMobyRelease() function attempts to find the cover for certain regions, it can't seem to find the right cover and instead selects another one. This seems to mostly affect PAL releases.

For example, when searching for the PAL cover of Donkey Kong Country 3: Dixie Kong's Double Trouble! it instead comes back with the Japanese cover, even though there are several PAL covers to choose from.

Other examples are sometimes selecting a non-English PAL cover when there is one available (such as here), and sometimes the wrong English PAL cover (such as here where it chooses the slip-case release instead of the normal UK release)

Expected result
Well the logic for finding the cover is quite messy and needs cleanup, so it's not unexpected that it has issues. Still, it should ultimately behave as intended and only fall back to the wrong image if no other suitable image is found.