rswinautomationsupport / rsmsmq

rsMSMQ

rsmsmq's Issues

Would it make sense to rename this repo?

Just thinking about this and while this module uses MSMQ at its core, its man function is to facilitate part of the provisioning process and a more descriptive name would be more suitable here and prevent confusion with an actual DSC MSMQ service configuration module?

Some ideas:
rsDSCPlatformConfiguration
rsDSCPlatformProvisioning
...etc

Thoughts anyone?

Test/Get-TargetResource not implemented

The get and test functions are not implemented, which causes Test-DscConfiguration to return $false when the configuration may or may not be valid.

https://github.com/rsWinAutomationSupport/rsMSMQ/blob/universal/DSCResources/RS_rsSendClientCert/RS_rsSendClientCert.psm1#L1-L31

Remove secrets.json dependency (rsProcessQueue)

Problem:
In line with the work to remove all direct dependencies on all external resources, this resource needs to be updated to convert direct access to secrets.json into resource parameter

Related code:
https://github.com/rsWinAutomationSupport/rsMSMQ/blob/master/DSCResources/RS_rsProcessQueue/RS_rsProcessQueue.psm1#L48

client cert creation in rsProcessQueue incompatible with databag exchange

Set-TargetResource function in RS_rsProcessQueue resource (at line 77-80) uses System.Security.Cryptography.X509Certificates class to create client cert and install on PullServer.

From what I'm seeing in on MSDN, I don't think it's possible to create a key exchange cert using this class.

https://msdn.microsoft.com/en-us/library/system.security.cryptography.x509certificates.x509certificate2%28v=vs.110%29.aspx

As such, generating the certificates in this manner is preventing DSC from encrypting a PSCredential for clients as the cert is not valid for key exchange. No error is thrown when running DSC but MOFs do not generate. Manually running throws an error about storing plaintext passwords in the MOF, leading me to believe this is the issue. Error text at the end of this message.

We'll need to hotfix this DSC resource to use makecert.exe instead.

Full error text:

ConvertTo-MOFInstance : System.InvalidOperationException error processing property 'Password' OF TYPE 'User': Converting and storing
encrypted passwords as plain text is not recommended. For more information on securing credentials in MOF file, please refer to MSDN
blog: http://go.microsoft.com/fwlink/?LinkId=393729
At C:\DevOps\Template-Client.ps1:46 char:9

• User
  At line:190 char:16

• $aliasId = ConvertTo-MOFInstance $keywordName $canonicalizedValue
  

•            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

  • CategoryInfo : InvalidOperation: (:) [Write-Error], InvalidOperationException
  • FullyQualifiedErrorId : FailToProcessProperty,ConvertTo-MOFInstance
    Errors occurred while processing configuration 'Client'.
    At C:\Windows\system32\WindowsPowerShell\v1.0\Modules\PSDesiredStateConfiguration\PSDesiredStateConfiguration.psm1:2223 char:5

• throw $errorRecord
  

• ~~~~~~~~~~~~~~~~~~
  

  • CategoryInfo : InvalidOperation: (Client:String) [], InvalidOperationException
  • FullyQualifiedErrorId : FailToProcessConfiguration