rubenrangel / scryscript

replace this

scryscript's Issues

Fulfill all GitHub community standards

https://github.com/rubenrangel/scryscript/community

Have Scryfall API errors reject client Promises

Currently, clients can return Promise<IError | ScryfallObject>. This causes the developer experience to introspect the response to know if it is usable:

const setsResponse: IError | IScryfallList<ISet> = await setClient.listSets(new ListSetsRequest());

if (setsResponse.object === 'error') {
  console.error(setsResponse.details) // type-safe access to `details`
} else {
  console.log(setsResponse.data) // type-safe access to `data`
}

The established try-catch flow is more naturally aligned to the usage pattern but has the tradeoff of not being able to describe the Type for the rejected value.

const setClient = new SetClient();
let sets: IScryfallList<ISet>;

try {
  sets = await setClient.listSets(new ListSetsRequest());
} catch (e) {
  // handle as desired
  throw e;
}

sets.data.forEach((data) => {
  // set data
});

Switch error handling to reject promises on Scryfall errors and resolve with the Scryfall objects.