rui314 / setup-mold Goto Github PK

Tried this on the CI setup of my Github repository but it doesn't seem to improve the compilation speed.

Does this action create a config.toml pointing to this linker by default? If not it would be useful if it did for Rust repositories!

We end up seeing this occasionally.

My guess is that wget from github occasionally fails. Most likely one or two retries inside the setup-mold step would go a long way here. Other suggestions welcome too.

When make-default is enabled and the action runs on the self-hosted runner, this action can fail with following error:

ln: ‘/usr/local/bin/mold’ and ‘/usr/local/bin/mold’ are the same file

This is because the self-hosted runner environment can be reused so that the symbolic link created by the previous run exists.
To resolve this, I think there are some options:

1. Check if there is an existing link before ln
2. Add cleanup steps to remove this symbolic link
3. Change nothing, and recommend to setup mold in their self-hosted runner by themselves

I'd like to hear your opinion. Thank you!

Hi @rui314,

Thank you for all the wonderful projects! 🥇 👍
And, thank you for this GitHub action!

I was trying to integrate this in a GitHub CI pipeline and observed this:

• mold is extracted to /usr/local/bin/mold
• but the symlink is created from /usr/bin/mold i.e.

  setup-mold/action.yml

  Line 17 in 1c4945c

  - run: test ${{ inputs.make-default }} = true && sudo ln -sf /usr/bin/mold $(realpath /usr/bin/ld); true

I had to add a separate step to fix the symlink creation from the correct path:

sudo ln -sf /usr/local/bin/mold $(realpath /usr/bin/ld)

Verified:

$ realpath /usr/bin/ld
/usr/local/bin/mold

$ ld --version
mold 1.1.1 (c1af9c97e763a1d521889191a83b27bd6c43b351; compatible with GNU ld)

I'll submit a PR shortly.
Thanks!