rui314 / syzygy Goto Github PK

Hello,

I've been trying to use syzygy to do binary instrumentation but I ran into
problems because the version of msdiaXXX.dll was wrong. On your wiki[1], the 
required version is msdia100.dll but the actual version required by the code 
was msdia120.dll. The latest commit in my szygy git checkout is 
766a0a17a11da0f6a7e25b749e95b3f255bc8ec1

The wiki should state the correct version of msdia(which is msdia120.dll) and 
that it comes prepacked with visual studio 2013.

It may be a small cosmetic change, but for someone like me who is not that savy 
in debugging these kind of issues it would've saved me a day and a half :) 




[1] - https://code.google.com/p/syzygy/wiki/SyzyASanHowTo

What steps will reproduce the problem?

1. Compile any ReactOS module.
2. Try to ASAN instrument it by following the instructions in the wiki.

What is the expected output? What do you see instead?

The instrumenter outputs errors that are about COFF, SEH table...etc

Trying with /SAFESEH fixes the SEH table issue, but the COFF errors remain, 
leading to no output file(s). Please note that we don't use /SAFESEH, we just 
tried it to test further.

What version of the product are you using? On what operating system?

We used the binaries provided in your repo.

Please provide any additional information below.

We're trying the ASAN instrumentation on ReactOS binaries as we aim for binary 
compatibility with Windows.