ruipfcosta / swiftywalkthrough Goto Github PK

View Code? Open in Web Editor NEW

373.0 12.0 47.0 3.84 MB

The easiest way to create a great walkthrough experience in your apps, powered by Swift.

License: MIT License

Objective-C 2.14% Swift 95.51% Ruby 2.36%

swiftywalkthrough's People

Stargazers

Watchers

swiftywalkthrough's Issues

Issue with Swift package manager

It says the following when trying a branch
"the manifest is missing a Swift tools version specification; consider prepending to the manifest '// swift-tools-version:5.4.0' to specify the current Swift toolchain version as the lowest Swift version supported by the project; if such a specification already exists, consider moving it to the top of the manifest, or prepending it with '//' to help Swift Package Manager find it in https://github.com/ruipfcosta/SwiftyWalkthrough"

And when trying newest version on master
"https://github.com/ruipfcosta/SwiftyWalkthrough has no Package.swift manifest for version 0.0.3 in https://github.com/ruipfcosta/SwiftyWalkthrough"

Any plans to update this for use with the latest XCode & Swift?

Carthage cannot build with swift 5

Since there is no release for swift 5, we can't simply use github "ruipfcosta/SwiftyWalkthrough" in the Cartfile. I made a repository here that has a swift 5 release - if you need to install with carthage, use the line:

github "Innoviox/SwiftyWalkthrough"

Not able to write in textfield.

Hi I am not able to write in textfield.

Button in customView

Hi, congratulations this is a vey good class.

I`m creating a subclass and inside has a button, i used your example of subclass to create mine subclass.

lazy var helpLabel: UILabel = self.makeHelpLabel()
lazy var titleLabel: UILabel = self.makeTitleLabel()
lazy var image: UIImageView = self.makeImage()
lazy var entendiBtn: UIButton = self.makeButton()

init() {
    super.init(frame: CGRectZero)
    self.userInteractionEnabled = true;

    addSubview(titleLabel)
    addSubview(helpLabel)
    addSubview(entendiBtn)

}

You know how i get touchevent on button?
I test override the method hittest, but called two times the delegate.

   override internal func hitTest(point: CGPoint, withEvent event: UIEvent?) -> UIView? {

        let currentView = self.entendiBtn
        let convertedPoint = currentView.convertPoint(point, fromView: self)

        if currentView.pointInside(convertedPoint, withEvent: event) {
            delegate?.willInteractWithView?(currentView)
            return currentView.hitTest(convertedPoint, withEvent: event)
        }

        return super.hitTest(point, withEvent: event)
    }

Can't build using carthage

I wish to this as a framework used for my project. However, when I use "carthage update", it gives me "Task failed with exit code 65:"

Unable to use it in Objective-C.

Segmentation Fault 11 using XCode 12.4 in willInteractWithView

Hi 👋

When building our project with XCode 12.4, a segmentation fault 11 occurs with the following stack trace

3.	While looking for 'willInteractWithView:'4.	While ...in 'UIViewController' (in module 'UIKit')
5.	[redacted]dlvqeumreafwivaaazjbchvrmbad/Build/Products/Debug-iphonesimulator/SwiftyWalkthrough/SwiftyWalkthrough.framework/Headers/SwiftyWalkthrough-Swift.h:216:1: importing 'WalkthroughViewDelegate::willInteractWithView:'
0  swift                    0x0000000113edd615 llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 37
1  swift                    0x0000000113edc615 llvm::sys::RunSignalHandlers() + 85
2  swift                    0x0000000113eddbcf SignalHandler(int) + 111
3  libsystem_platform.dylib 0x00007fff6cff75fd _sigtramp + 29
4  libsystem_platform.dylib 000000000000000000 _sigtramp + 18446603338687482400
5  swift                    0x0000000110a4bf41 (anonymous namespace)::SwiftDeclConverter::VisitObjCMethodDecl(clang::ObjCMethodDecl const*) + 321
6  swift                    0x0000000110a3497d swift::ClangImporter::Implementation::importDeclAndCacheImpl(clang::NamedDecl const*, swift::importer::ImportNameVersion, bool, bool) + 1469
7  swift                    0x0000000110a1ea3c swift::ClangImporter::loadObjCMethods(swift::ClassDecl*, swift::ObjCSelector, bool, unsigned int, llvm::TinyPtrVector<swift::AbstractFunctionDecl*>&) + 284
8  swift                    0x0000000110b8919d swift::ASTContext::loadObjCMethods(swift::ClassDecl*, swift::ObjCSelector, bool, unsigned int, llvm::TinyPtrVector<swift::AbstractFunctionDecl*>&) + 301
9  swift                    0x0000000110d5bc64 swift::ClassDecl::lookupDirect(swift::ObjCSelector, bool) + 180
10 swift                    0x0000000110923776 lookupObjCMethodInClass(swift::ClassDecl*, swift::ObjCSelector, bool, bool, swift::SourceManager&, bool) + 54
11 swift                    0x0000000110923180 swift::diagnoseUnintendedObjCMethodOverrides(swift::SourceFile&) + 944
12 swift                    0x0000000110a0518a swift::performWholeModuleTypeChecking(swift::SourceFile&) + 250
13 swift                    0x000000010fb7d0ad swift::CompilerInstance::performSemaUpTo(swift::SourceFile::ASTStage_t) + 8237
14 swift                    0x000000010fa3d771 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 6833
15 swift                    0x000000010f9c1c27 main + 1255
16 libdyld.dylib            0x00007fff6cdfecc9 start + 1
17 libdyld.dylib            0x00000000000001fe start + 18446603338689549622

It seems that the ff offending code inWalkthroughView can be rewritten while Apple fixes this compiler issue

@objc public protocol WalkthroughViewDelegate {
    @objc optional func willInteractWithView(_ view: UIView)
}

Thanks!

Environment:
Xcode 12.4
MacOS Catalina 10.15.5

Please make a release to CocoaPods

@ruipfcosta the CocoaPods version of SwiftyWalktrough is not up to date with the source code located here. Please make a release to CocoaPods or allow me or someone else to update it as an contributor 🙏. I have a old project that I want to bring back to life and it depends upon your awesome package.

ruipfcosta / swiftywalkthrough Goto Github PK

swiftywalkthrough's People

Stargazers

Watchers

Forkers

swiftywalkthrough's Issues

Issue with Swift package manager

Any plans to update this for use with the latest XCode & Swift?

Carthage cannot build with swift 5

Not able to write in textfield.

Button in customView

Can't build using carthage

Unable to use it in Objective-C.

Segmentation Fault 11 using XCode 12.4 in willInteractWithView

Please make a release to CocoaPods

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Jobs