rumyantseva / go-velobike

Unofficial Go client library to deal with REST API of velobike.ru project 🚲

Hello and welcome!

I hope you will find something useful here 🤓

My name is Elena Grahovac, I develop a truly Open Source MongoDB alternative at @FerretDB.

The main topics of this account are DevOps culture and the Go programming language.

Recent:

• Mastering the Art of Wearing Many Hats.
• Engineering Manager's Responsibilities Mindmap.

Other links:

• Videos of some talks and workshops I have given (mostly in Russian).
• My twitter: @webdeva, if you have a question feel free to ping me there.
• Other ways to contact me: grahovac.pro.

go-velobike's Issues

go linter issues

Linter warns what some variables should have different names:

velobike/authorize.go:11:2: struct field SessionId should be SessionID
velobike/history.go:16:2: struct field Id should be ID
velobike/parkings.go:17:2: struct field Id should be ID
velobike/profile.go:10:2: struct field UserId should be UserID
velobike/profile.go:16:2: struct field AvatarUrl should be AvatarURL
velobike/profile.go:22:2: struct field TariffId should be TariffID
velobike/velobike.go:12:2: const baseUrl should be baseURL
velobike/velobike.go:30:2: struct field SessionId should be SessionID

It's not possible to change it in the current major version (0.x.x) because it'll break back compatibility.
So, this issue should be fixed in the next major version (1.0.0).

Add golangci integration

The golangci project (https://golangci.com) offers free support for open source projects and libraries.
It might make sense to add golangci integration to this project (and fix the issues which golangci report against this library).

API has been closed?

https://apivelobike.velobike.ru/ returns 404 Not Found. They've closed their API?

Dealing with Time fields

Response bodies contain some fields related with time. For example, StartDate and Duration. Right now we handle these fields as strings but for the next major version it's better to parse this data to time.Time type.

Add continuous integration configuration

It might be helpful to compile library and run examples every time when code changes.

So, looks like we need to add Travis CI configuration here, yeah.

Examples no longer compile after fix for #2

The examples no long compile after the fix for #2.

An example of this is L36 in the history example:

client.SessionId = auth.SessionId

This should be:

client.SessionID = auth.SessionID

All other examples suffer the same issue.