GithubHelp home page GithubHelp logo

Comments (3)

ehildenb avatar ehildenb commented on July 20, 2024

We should not be copying the code cell from the output of the setUp function, just the storage, origStorage, balance, and nonce. That way, it won't break in this way. Requires modification here:

from evm-semantics.

nwatson22 avatar nwatson22 commented on July 20, 2024

We should not be copying the code cell from the output of the setUp function, just the storage, origStorage, balance, and nonce. That way, it won't break in this way. Requires modification here:

@ehildenb Are you sure that is the preferable behavior (just copying storage, origStorage, balance, and nonce? I am thinking about the case where setUp() creates a contract. In that case wouldn't we want the account for that contract to be copied with its code?

I tried to address the issue in #2064 now by, after copying the accounts cell, overwriting the code cell for the account Foundry.address_TEST_CONTRACT() to make sure it gets the newer version of the code.

from evm-semantics.

ehildenb avatar ehildenb commented on July 20, 2024

Yeah, if the setup function creates another contract, that should be copied as well. But the code from the test contract shouldn't be included I think, because that code can change even if the setup or storage doesn't.

from evm-semantics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.