Comments (3)
I think I'm kind of softening on this as time goes on. But stuff like this is still going to always be behind a scarily-named feature, and probably exposed in a deliberately obtuse place in the API. I guess this is similar to PR #64
from rustls.
I am ok with that; I solemnly swear that I'll never use the scarily named option without a long comment explaining why in this very narrow context it's ok.
If you can suggest where in the API you'd like it, I'm happy to send a PR.
from rustls.
Here's a proposal:
- New feature
dangerous_configuration
, which you have to enable in order to be able to use this stuff - On
rustls::ServerConfig
add adangerous_configuration
field, which is an instance ofOption<rustls::DangerousServerConfig>
rustls::DangerousServerConfig
has adisable_certificate_verification
bool
field- None of these fields exist unless the
dangerous_configuration
feature is enabled.
I think this makes things relatively inaccessible -- it also means that if a library wants to use all this, it's clearly propagated in a way that consumers can see it.
from rustls.
Related Issues (20)
- How can I explicitly disable TLS 1.3 in the config builder API and/or improve logging? HOT 2
- Please provide ClientConfig/ServerConfig functions that use an enabled CryptoProvider automatically HOT 7
- Compile error when target is wasm HOT 2
- Address difficulty upgrading between versions HOT 9
- Weird BoGo failure related with EarlyData HOT 1
- TLS1.3 performance problem HOT 8
- Request for Information on Dedicated discussion Channel for Rustls like Element.io or Discord Alternatives? HOT 3
- use openssl not get Panic,use rusttls get panic HOT 4
- BadRecordMac, client abort connection after several packets after handshake HOT 9
- Randomly getting `InappropriateHandshakeMessage` HOT 1
- 0.23 release preparation HOT 9
- Support for some clipersuite to connect Microsoft-IIS 8.5 server HOT 6
- Current main fails to compile aws-lc-sys HOT 18
- When accepting new TLS connection with Accepted::into_connection(config) no TLS alert is sent HOT 17
- Is there any benchmark comparison of existing TLS libraries in other languages like java, C++ and python etc. with Rustls ? HOT 6
- Random with 0 system entropy - workarounds? HOT 2
- Be able to get the not_before and not_after through some API in CertifiedKey or CertificateDer<'_>. HOT 6
- ServerConnection data lost HOT 3
- Async code in `ProducesTickets` implementation HOT 2
- `ServerHelloPayload` re-export inquery/request HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rustls.