GithubHelp home page GithubHelp logo

Comments (3)

ctz avatar ctz commented on May 14, 2024

I think I'm kind of softening on this as time goes on. But stuff like this is still going to always be behind a scarily-named feature, and probably exposed in a deliberately obtuse place in the API. I guess this is similar to PR #64

from rustls.

alex avatar alex commented on May 14, 2024

I am ok with that; I solemnly swear that I'll never use the scarily named option without a long comment explaining why in this very narrow context it's ok.

If you can suggest where in the API you'd like it, I'm happy to send a PR.

from rustls.

alex avatar alex commented on May 14, 2024

Here's a proposal:

  • New feature dangerous_configuration, which you have to enable in order to be able to use this stuff
  • On rustls::ServerConfig add a dangerous_configuration field, which is an instance of Option<rustls::DangerousServerConfig>
  • rustls::DangerousServerConfig has a disable_certificate_verification bool field
  • None of these fields exist unless the dangerous_configuration feature is enabled.

I think this makes things relatively inaccessible -- it also means that if a library wants to use all this, it's clearly propagated in a way that consumers can see it.

from rustls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.