rustrial / aws-eks-iam-auth-controller Goto Github PK

It would be awesome if we could get support for JSON logging configurable with an environment variable.

When running kubectl -n <namespace> get all command. We can see that all iamidentitymappings.iamauthenticator.k8s.aws resources appears event if those resources are not namespaced.

NAME                                                                                                    AGE
iamidentitymapping.iamauthenticator.k8s.aws/circleci-kubernetes-deployer-xxx                            166d
iamidentitymapping.iamauthenticator.k8s.aws/circleci-kubernetes-deployer-abc                            166d
iamidentitymapping.iamauthenticator.k8s.aws/circleci-kubernetes-deployer-123                            166d
iamidentitymapping.iamauthenticator.k8s.aws/circleci-kubernetes-deployer-456                            166d

First of all, thanks for writing this! It's a great addition to improve reliability of my automation.

aws-eks-iam-auth-controller is a critical cluster component. It should receive priority during scheduling, because its unavailability may prevent clusters from recovering in certain situations. The easiest way to do so is by setting the Pod Priority Class to system-cluster-critical.

I will open a pull request in a few minutes to address this.

Not sure if the controller reconciles only against iamidentitymapping custom resources. If so, it can potentially remove entries in aws-auth that grant access to the cluster.

Thanks for putting this together! 🙌

The status subresource in a CRD is used to represent the current state of the resource, in addition to the spec for desired state.

https://github.com/kubernetes-sigs/aws-iam-authenticator added support for the status subresource a little while ago.

• https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/3502ca14a5d908436b26a4116117f4c38872f51a/deploy/iamidentitymapping.yaml#L37
• kubernetes-sigs/aws-iam-authenticator@8883cfe

It would be great if support for status and updating it could be added to this controller to complete the reconcile/feedback loop.