ruyadorno / angular-simple-slider

An AngularJS directive providing a simple slider functionality

ruyadorno

Open-source maintainer, Node.js TSC & member of the Node.js Release Team. Currently working on building the future of JavaScript packages at vlt /vōlt/. Previously working with Node.js / open-source libraries at Google and Software Developer at the npm cli team at GitHub prior to that.

I also speak at conferences and meetups from time to time, you can find some of the presented content on Speaker Deck and Youtube.

Find more info on my personal website at https://ruyadorno.com

angular-simple-slider's Issues

Add config provider

Add a simpleSliderConfigProvider with defaults for every slider created through the directive

Current attribute assumes next/prev is a string

Want to say thanks for the great work, I just found a minor bug.
The "current-slide" attribute assumes the next/prev parameters are strings.
And if a 0 (integer) next index is passed to it,
if (next && next !== prev)
evaluates to false.

It took me a while to figure out why the current slide was not working for me when I was using $index inside an ngRepeat. It was easy to fix by casting $index to string, but I think it would be better to change the conditional to something like
if (next !== undefined && next !== prev)

Improve docs

Explain more about the directive qualities such as double binding SimpleSlider instance, current slide attr, etc.

Using ng-repeat

Hey, really cool slider man!
my only issue is when i try to use the ng-repeat i get an "A SimpleSlider main container elementshould have at least one child." Error..

anyway to fix it?

thanks,
Lior.

Update bower and create new version

Bower is still on ~1.0.0 and downloads that version, not the latest master version

Provider 'SimpleSliderService' must return a value from $get factory method.

Im getting a error with your example (directive without arguments) Im using Angular 2.3.4 and i found this.

angular/angular.js#9801

I was reading the code and i saw that you are returning a object of windows, but maybe is null.

Any fix/tip?
Thanks.

Error: [$injector:undef] Provider 'SimpleSliderService' must return a value from $get factory method.
http://errors.angularjs.org/1.3.4/$injector/undef?p0=SimpleSliderService
at http://localhost:8080/app.js:14:411
at Object.$get (http://localhost:8080/app.js:14:16003)
at Object.i as invoke
at http://localhost:8080/app.js:14:18047
at r (http://localhost:8080/app.js:14:17165)
at Object.i as invoke
at http://localhost:8080/app.js:14:23062
at o (http://localhost:8080/app.js:14:796)
at Object. (http://localhost:8080/app.js:14:23029)
at Object.i as invokeapp.js:15 (anonymous function)app.js:15 (anonymous function)app.js:14 (anonymous function)app.js:14 oapp.js:14 (anonymous function)app.js:14 iapp.js:14 (anonymous function)app.js:14 iapp.js:14 (anonymous function)app.js:14 rapp.js:14 zapp.js:14 Iapp.js:14 Rapp.js:14 Rapp.js:14 Rapp.js:14 Rapp.js:14 Napp.js:8 linkapp.js:15 oeapp.js:14 bapp.js:14 sapp.js:14 (anonymous function)app.js:14 P.rapp.js:14 lapp.js:8 lapp.js:16 f.$broadcastapp.js:8 (anonymous function)app.js:15 uapp.js:15 (anonymous function)app.js:16 f.$evalapp.js:15 f.$digestapp.js:16 f.$applyapp.js:14 (anonymous function)app.js:14 iapp.js:14 X.sapp.js:14 Xapp.js:14 Kapp.js:18 (anonymous function)app.js:16 rapp.js:14 n
app.js:15

Error: [$injector:unpr] Unknown provider: oProvider <- o
http://errors.angularjs.org/1.3.4/$injector/unpr?p0=oProvider%20%3C-"

"
at http://localhost:8080/app.js:14:411
at http://localhost:8080/app.js:14:17934
at Object.r as get
at http://localhost:8080/app.js:14:18029
at r (http://localhost:8080/app.js:14:17165)
at i (http://localhost:8080/app.js:14:17489)
at Object.o as instantiate
at http://localhost:8080/app.js:15:5962
at link (http://localhost:8080/app.js:8:4035)
at oe (http://localhost:8080/app.js:15:2958)

Slider stops working when the scope values change

I have a function where the user can change the images in the slider, when it's done I just replace the existing list of images in scope with the new one.

I can see the model updates correctly, but when it's done the slider no longer plays the slideshow and I can't navigate through images.

Is there a way or some function to "reset" the slider?

Enable pauseOnHover behavior

Hello!

Really cool plugin man!

Do you know hoy I can implement a pauseonHover behavior on your slider?

Thanks a lot!

Add tests

karma tests are already configured but there are no tests at all running at the moment.

Adding some tests will make the module much easier to be maintained in the long term.

Update to [email protected]

Add support to dispose method