rvagg / jsonist Goto Github PK

The latest update from 2.1.0 to 2.1.1 has changed usages of 'var' to 'let', which is a breaking change for anyone using node versions < 6. This package is not a direct dependency of ours and therefore we do not control the version. Our version of node cannot be upgraded for legacy reasons, and we are now unable to redeploy our server.

Could you please publish a new patch version which reverts to 'var', and republish your latest version as either a minor or major version.

then it won't work behind firewalls.

If an endpoint is expecting JSON but hits, say, a 404 returning text/plain, the JSON is still attempted to be parsed and a Syntax Error is returned as the err to the callback. But you may want to handle that differently to an actual syntax error. I suggest the response code & mime-type should be checked before the body is parsed, and maybe return a jsonist.NOT_JSON_ERROR instead of a SyntaxError so we can differentiate the classes of failure.

Current output for a http server sending back text/plain as "Not Found":

Hi Rod. I would find the addition of delete method useful. Is this something you would consider merging into jsonist? I will submit a PR if so. Thanks.