rwaldron / grunt-compare-size

npx rwaldron

Or

npx rwaldron --xmas

grunt-compare-size's Issues

Investigate gzip size accuracy

The uglify task is making some bold claims about the size of jQuery after minification and gzip:

Output is too verbose with multiple branches

Now that the plugin compares to all branches, it's incredibly verbose when you've merged, built, and landed several branches. The output even continues for deleted branches. My output was more than a screen before I blew away my size cache.

Silent failure if git command line not found

If git is not installed or if it otherwise cannot be found on the command line (still need to figure that one out) the git_current_branch helper called by the compare_size task fails silently.

Problem in Windows 7 64bits

I have no idea what goes wrong but I see no file added into dist. At one point there was one in build.

I installed the package using (native windows) npm locally.

Anyway, just wanted to let you know... nodejs v 0.6.13

Still a release candidate?

Maybe it's time to remove "rc.3"?

min.js file may not be the last in the file list, and there could be multiples

Now that jQuery core has a map, the map file comes last. I think we can make the map file come second but it seems unnatural to do that. I'm never sure which assumptions are safest to make.

https://github.com/rwldrn/grunt-compare-size/blob/184f038119b4c4a0afba8a743d83bee755bda8bd/tasks/compare-size.js#L82

Why not add gruntplugin keyword on npm site?

Hello
Your package does not appear on grunt website, because the package displayed must be published on npm with the gruntplugin keyword.http://gruntjs.com/plugins

Best regards.

Less bytes => good, not red

Currently reduced number of bytes is displayed in red, increased in yellow. Should be the other way round?

Docs suck

The main task, compare_size, isn't even mentioned in the readme.

Provide a changelog

That would allow keep tracking of the changes for developers outside jquery project using this task.

Avoiding really long reports

At this point my compare-size report is 44 lines long (well really 88 with the double spacing) and the actual gzipped size of the current build (29501 in this case) is inevitably way off the screen. I think there was some discussion of trimming this list automatically.

Is this a problem anyone else encounters? Are you just typing grunt compare_size:empty and starting from scratch when it gets this long?

Perhaps there could be a config option to only keep/show specific branches so it doesn't need to be pruned so often. I tend to only care about the main branches (master and 1.x-master now) versus the branch I'm working on.

At minimum it would seem to make sense to have the sizes for the build that just finished at the bottom below the compared branches so that it wouldn't be scrolled off.

Running "compare_size:files" (compare_size) task
   raw     gz Sizes                                                             
239554  71011 dist/jquery.js                                                    
 82926  29501 dist/jquery.min.js                                                

   raw     gz Compared to master @ 32b066d3805a48f8c8312562ed52a1b5910b1d85     
     =      = dist/jquery.js                                                    
     =      = dist/jquery.min.js                                                

   raw     gz Compared to 1.9-stable @ a3055f3df63661ad1221db44d04ec92ece130a8c 
-28043      ? dist/jquery.js                                                    
-10132  -3484 dist/jquery.min.js                                                

   raw     gz Compared to x13183 @ 3413849917542d5be132cccd2f1171347f412700     
-27781      ? dist/jquery.js                                                    
-10152  -3498 dist/jquery.min.js                                                

   raw     gz Compared to p1194 @ addd35ecbc949ccb79416af27819d0d2e87fd4e3      
   +76    +14 dist/jquery.js                                                    
   +36     +9 dist/jquery.min.js                                                

   raw     gz Compared to 1.x-master @ 58b8535d5d00a09660d87a6a8e1c86a478e416fc 
-32367  -9942 dist/jquery.js                                                    
-10335  -3399 dist/jquery.min.js                                                

   raw     gz Compared to p1204 @ bd8739acf4e995554324762a2f7a7f7c5fbb0c59      
-31694  -9760 dist/jquery.js                                                    
-10244  -3371 dist/jquery.min.js                                                

   raw     gz Compared to p1203 @ ad5ca1194780d3d7e653751ff33bb1c06f3812ff      
  -342   -120 dist/jquery.js                                                    
   -51    -17 dist/jquery.min.js                                                

   raw     gz Compared to p1207 @ 7ab3630ae633ffffef3bd7bb52d6d1fbbfe3c4a5      
     =     +1 dist/jquery.js                                                    
     =      = dist/jquery.min.js                                                

   raw     gz Compared to last run                                              
     =      = dist/jquery.js                                                    
     =      = dist/jquery.min.js                                                

Saved as: master

Done, without errors.

Go back to multi task

What's with the dropping support for multiple targets, aka multi task? jQuery UI used that, now its gone, since 6757d05

Output is double-spaced on Windows

One, output double spaced on my command window, is that intended or is it some issue that's Windows-specific? http://wnd8.com/grab/714af8.png