saadmk11 / django-newsfeed Goto Github PK

When on /newsfeed/subscribe/ and I type in an email address, the emails do not get sent to that email address.

Is this because I did not set up celery?

By adding signals for post subscription and post unsubscription users will have more control over what happens after those event and they can integrate other services with it.

Changelog CI: https://github.com/saadmk11/changelog-ci

There should be a way to encrypt/decrypt emails in the database because emails fall into GDPR / PII / Privacy laws. Perhaps using a database setting like NEWSFEED_EMAIL_ENCRYPT = True|False would enable/disable this feature. This way if your database was ever stolen/hacked, the attacker would not be able to see the emails.

But If someone changes this setting later on the user would probably need to do some sort of data migrations. https://docs.djangoproject.com/en/3.1/howto/writing-migrations/ which is not really desirable. Unless it can somehow get built into the app?

SELECT SQL queries and django get() should be able to view the decrypted emails.

Some ideas would be to do something like django-fernet-fields which uses the SECRET_KEY to do both the encryption and decryption. Or if you are using postgres, do something like django-pgcrypto-fields which uses a postgres pgcrypto extension.

The current architecture allows malicious unsubscribe. The solution adopted by mailchimp, for example, is to only allow unsubscribe via a link sent with every email, which contains a token which is used to verify authenticity. I'm not sure if this should be the only route to unsubscribe, but it should certainly be an option.

Presumably, the token should be fixed for a given user, so that the unsubscribe link works from any email. Although what happens if a naive user forwards a newsletter? I think one needs a "You have been unsubscribed, if this wasn't your intention, you can resubscribe by clicking this link" confirmation email, perhaps?

Users will be able to subscribe to the newsfeed and will receive newsletters for each issue