sababhamidipati / mod_0_assessment Goto Github PK

Hi Saba, I reviewed your assessment and there are some changes that I’d like for you to make before we consider you technical ready. Please have them done by EOD Monday and send me a slack message once completed!

First, on a positive note, I love that you included multiple methods that perform the same action in your variables.rb file! It's great to have multiple tools in your back pocket.

SOMETHING TO THINK ABOUT

• I'm not as familiar with Ruby and I've asked a question to our back-end team, but I noticed that you are using both symbols and strings for your keys in your hash examples. Typically, I try to keep things consistent in my code, so either all symbols or all strings. However, I don't know if this is actually a best practice or just a me thing. From my understanding string keys are "mutable," meaning their values can be changed later, whereas a symbol key is "immutable." I could see a world where you actually do want some of your keys to be mutable and others immutable, in which case you would need both types of keys in your hash, but the inconsistent syntax stood out to me, so I thought I would highlight it! I'll let you know when I get a response from the team. For example, in your airport hash, the first two key-value pairs use symbols name: 'OHare', but then all of the others use strings "number_of_flights" => 500. TBD on what best-practice is here.

MUST BE CHANGED

• For your hashes in both your model_a.rb and model_b.rb files, make sure you indent all of the key-value pairs.

Send me a DM on Slack when you've completed these changes! Thank you.