sabof / php-eldoc Goto Github PK

A few points of feedback having read through the code:

1. Perhaps it would even be possible to invoke probe.php using the command-line php executable and adjusting the PHP include_path to point at the project being inspected.
2. You should also include some ;;;###autoload cookies, at least for php-eldoc-enable, and I'd also suggest autoloading the setup hook:

;;;###autoload
(add-hook 'php-mode 'php-eldoc-enable)

1. ac-sources is not buffer-local, so you shouldn't add ac-source-php-eldoc to it every time php-eldoc-enable is called; either make ac-sources buffer-local, or just add the source once at global scope. (Making the var buffer local would be preferable IMO.)

Hope that helps!

-Steve

I get the above error when running php-eldoc-enable. It appears to arise from this code:

  (when (and (fboundp 'auto-complete-mode)
             auto-complete-mode)...

This seems to fix it:

  (when (and (fboundp 'auto-complete-mode)
             (auto-complete-mode))...