sachatrauwaen / openurlrewriter Goto Github PK

Hi, I love this module, it come on with very useful providers!
It is one of the fundamental modules that I use for my work!
The problem is that with latest DNN 9.6.2 and with 2SXC 11.04.00 it give me some problem.
https://github.com/dnnsoftware/Dnn.Platform/issues/3816
https://github.com/2sic/2sxc/issues/2144
Is there any possibility of making a new release with the necessary corrections to make this module compatible again with these latest versions?

Hi,
Installing latest OpenUrlRewriter71_01.04.04_Install.zip and all seem to work fine, host extension is opened well with http://mywebsite/host/extensions?portalid=1
After installed OpenUrlRewriter71_01.04.04_Install.zip if I open OpenUrlRewriter71_01.04.04_Source.zip and recompile the dll without any modification and all work fine except for all host menu, for example host extension is opened with url http://mywebsite/host/extensions/portalid/1 with 404 page not found.
If I replace the dll with install version all resume to work fine.
There are some difference between Installand source version? How is it possible if they have the same source code?
Could be a target framework issue? I'm compiling with target 4.5.2

I'd like to know if the module works on the most recent DNN - 9.11+ - specifically along with the Sql_OpenUrlRewriter module

I rely on this for decent indexing and would love to help upgrade or test if needed.

We have a module that transforms a friendly URL like /page/rvdwktid/topic-12 to /page/topic This works properly on all version of standard DNN 9.1, 9.4 and 9.5.

After installing the OpenUrlRewriter 1.4.4 the module rewrite does not work anymore. We can see that a link gets transformed to /page/topic but upon clicking on it, it does not transform back to necessary query strong form. We traced the code and found that the provider's TransformFriendlyUrlToQueryString() method never gets called to rewrite.

We ran a test with the OpenUrlRewriter on different DNN versions and here is the result of the finding:

On DNN 9.1 it works correctly.

On DNN 9.4 it works but the URL is not optimally rewritten e.g. we get /page/rvdwktid/topic-12 instead of the expected /page/topic

On DNN 9.5 it's completely broken. The module's TransformFriendlyUrlToQueryString() never gets called when the link /page/topic is clicked so it cannot navigate properly.

If we simply switch the web.config back to defaultProvider="DNNFriendlyUrl", it still does not work. Only by uninstalling the OpenUrlRewriter completely that it starts to work correctly again.

Can you please help?

Installing Vanjaro on latest DNN 9.10.00 I'm no able to reach the Vanjaro Api call at this url: http://www.testsite.com/api/vanjaro/page/get?_=1628169543689
Is there any Stored url rules I can add on OpenUrlRewriter to make it work?
Thanks!

Hi,
looking at event log I can see a lot of errors log from UrlRewriter.UrlRuleConfig: GetConfig whit error message "Null object cannot be converted to a value type."
Looking moore deep it look something linked to Ventrian PA Open Url Rewrite provider but with exception fired to OpenUrlRewriter.
So I decided to debug the code to find where the problem could be.
The problem is on AddUrlRule in UrlRuleController.cs
Here is defined the function AddUrlRule with DotNetNuke.Data.DataProvider.Instance().ExecuteScalarDB call
The problem is that it can't be converted to an Int32, as integers are value types and cannot be null. Either check the return value for DbNull and return a default value from your data layer, or check your query and database to ensure that a null will not be returned.
This fired all exceptions.
There are much ways to fix this, below my solution:

public static int AddUrlRule(UrlRuleInfo objUrlRule)
        {
            object result = DotNetNuke.Data.DataProvider.Instance().ExecuteScalar(ModuleQualifier + "AddUrlRule",
                                          objUrlRule.DateTime,
                                          objUrlRule.UserId,
                                          objUrlRule.RuleType,
                                          GetNull(objUrlRule.CultureCode),
                                          objUrlRule.PortalId,
                                          GetNull(objUrlRule.TabId),
                                          GetNull(objUrlRule.Parameters),
                                          objUrlRule.RemoveTab,
                                          objUrlRule.RuleAction,
                                          GetNull(objUrlRule.Url),
                                          GetNull(objUrlRule.RedirectDestination),
                                          GetNull(objUrlRule.RedirectStatus)
                                        );
            if (result == DBNull.Value)
            {
                return 0;
            }
            else
            {
                return Convert.ToInt32(result);
            }
            


        }

Please @sachatrauwaen if you can fix on the next release.
Thanks.

Is it possible disable the OpenUrlProvider rules for a specific Tab?
If yes, can someone give me an example?
Thanks