safayildirim / file-differ Goto Github PK

Hello, I tried the application and tested a little bit. According to my tests I see when I compare two files the application excepts every line as a new line created. I think the application should store one files information then compare with the other or others. I mean it should be like testfile1.txt diff testfile2.txt. Don't get confused I am not talking about the usage on CLI I am talking about the idea.

First of all in class MyFileReader you should change the class name or you should extract the write methods from this class. Because when I look at the class a.k.a FileReader. I expect this class to read file. But when I try to implement this class I see that this class exposes readIntoMap(), readHTML() and writeHTML(). Maybe those read methods will be exceptable but I think you should extract the writeHTML() method.