safe-global / safe-android Goto Github PK

https://issuetracker.google.com/issues/64804587

Expected behavior

When changing my device password, I should first get asked to enter a new password.

Actual behavior

I get asked first to repeat/confirm a password before even entering one.

Steps to reproduce the behavior

• Go to setting
• Change device pw
• Enter current device pw
• Now the repeat input field is focussed, but the "new pw" field should be.

Additional Information

• Device: Gnosis Huawei
• OS version: 8.0.0
• App version: 0.6.1-dev

• Adjust design
• Adjust architecture
• Add tests

Expected behavior

Clicking reject should reject tx in FE and throw error w/message ~ 'User rejected transaction .... '

Mobile notifications pending should NOT come in
OR
clicking accept on mobile notification AFTER rejecting in browser Extension should NOT approve or do anything when clicking

Actual behavior

1. Mobile Gnosis Safe App was not unlocked before initiating tx on dapp
2. Start tx on app with browser extension unlocked
3. extension shows pending tx please accept on mobile app
4. unlock mobile app but no notification received ...
5. lock browser extension and unlock browser extension
6. Click 'reject' on browser extension
7. tx does NOT reject
8. mobile notification came in late
9. approved mobile notification and tx was mined successfully

Steps to reproduce the behavior

1. Mobile Gnosis Safe App was not unlocked before initiating tx on dapp
2. Start tx on app with browser extension unlocked
3. extension shows pending tx please accept on mobile app
4. unlock mobile app but no notification received ...
5. lock browser extension and unlock browser extension
6. Click 'reject' on browser extension
7. tx does NOT reject
8. mobile notification came in late
9. approved mobile notification and tx was mined successfully

Additional information

• Device: Galaxy J5 (2016)
• Android OS version: 7.1.1
• Safe app version: 0.2.2

As the pin is too short and hashing is not really secure we should use scrypt to improve that.

https://github.com/wg/scrypt

• Change design of generate mnemonic
• Change design of restore mnemonic
• Add longpress to copy mnemonic
• Remove initial screen to select generate or restore and add a restore option to the generate screen
• Adjust architecture for both screens
• Add tests for both screens

• Choose any activity or fragment and add UI test for it
• Dependencies should be mocked
• Test coverage should be close to 100%

• use release task for tests (right now it is using debug)

Story: https://gitlab.gnosisdev.com/wallets/safe/blob/master/personal_edition/milestones/1_mainnet/story_recovery_phrase.md

• Add possibility to add and remove entries to an address book (address and name should be mandatory). Also add screen that lists all stored entries
• Show if an address is stored and display the name (e.g. when performing transactions or displaying owners of a safe)

Make of our abi parser library https://github.com/gnosis/abi-kotlin

Please log in to Travis CI and activate heimdall-android app.
we can use the image file of the badge in the README file.

Image file: https://api.travis-ci.org/gnosis/heimdall-android.svg or something similar.

• Create helper functions file
• Create dependencies file
• Make sure buildserver can handle it

Expected behavior

When unlocking the app the unlock screen should show up without any "flashing" (ie.: target screen being briefly shown)

Actual behavior

When I unlock the app there is a short moment where you see a white background. Preferably this would not happen

Steps to reproduce the behaviour

Open the application whenever it is on a locked state.

Additional information

• Device: Pixel 2
• Android OS version: 9
• Safe app version: 0.6.3

Making an unlock session for X amt of time option to allow easier confirmation of multiple transactions in a row.

E.g. when interacting with the DutchX multiple transactions have to be performed in a row. Each time the user has to type their password again. Adding this feature would a low an easier interaction in these cases.

• Change design of all screens
• Change architecture for all screen
• Add tests for all screen

Please list the screens here when working on the ticket.

Expected behavior

After changing the password it can be used to confirm a transaction

Actual behavior

After changing the password you cannot confirm the transaction for submission
https://drive.google.com/file/d/1LvN5p3i3lm6-i4mkoQZVwedBm6FKsO3a/view?usp=sharing

Steps to reproduce the behavior

Here’s a video and the steps:

• change app password
• initiate send ETH
• confirm with chrome extension
• submit transaction with app
• screen greys out and button is replaced by an unresponsive white bar. (in last week’s user test, a red error message appeared.)
• user clicks outside white bar to go back to pending transaction
• try to submit transaction again
• white bar appears again
  …
• i tried this whole flow 3 times and got the white bar consistently and couldn’t move forward. On the final try, I did get the password/fingerprint prompt on the 3rd try. Then the transaction seemed to move forward (see video).
• when the user tried it last week, he received an error message that said password was not recognized.

Additional information

• Device:
  NA
• OS version:
  NA
• App version:
  NA

• Adjust travis config to execute test
• Add codecov

• Add style for primary button (full width)
• Add style for inline button
• Add style for text button
• Add style for toolbar (and toolbar text)/ navbar (and navbar items)
• Add style for activity (windowBackground)
• Add style for different types of text (e.g. title, content, label, input) -> set at least textColor and textSize
• Add custom font (Can be done via Text style)

Use encryption for:

• storing private keys
• storing mnemonic phrase
   

• show name
• show balance
• show transactions
• show owners
• show number of required confirmations
• show tokens
• add test

• Change design
• Change architecture
• Add tests

• Change Design
• Change architecture
• Add tests

Choose appropriate licence and add LICENCE file

• Add pull to refresh
• Adjust design
• Add different loading spinner for qr code generation
• Change architecture
• Add tests

https://github.com/gnosis/heimdall-android/community

Extract rpc api into separate module

Combine multiple rpc calls:

[{
"method": "eth_estimateGas",
"params": ["0xa5056c8efadb5d6a1a6eb0176615692b6e648313"],
"jsonrpc":"2.0",
"id": 42
},{
"method": "eth_gasPrice",
"params": [],
"jsonrpc":"2.0",
"id": 45
},{
"method": "eth_getTransactionCount",
"params": [
"0xa5056c8efadb5d6a1a6eb0176615692b6e648313",
"latest"
],
"jsonrpc": "3.0",
"id": "dkhfgs"
}]

• The app should be locked by default.
• The user needs to unlock it before he can use it.
• All private data should be encrypted

• Change design of splash
• Splash should not displayed longer than necessary

First of all - congratulations to the release. Just had the chance to try it out yesterday - and really like what I saw and was able to make a transaction without any problem! Big up @rmeissner , @fmrsabino and the rest - good job!!
Now I have a small UX problem: I forgot the password I was using yesterday. and there is no option to dump the key so I could access the account again when I remember the password again (I think this will happen as soon as I see the password constraint list again)
The password constraints where also a bit disappointing to me - I really do not like these things and have to reference XKCD here

anyway - this is complaining on a high comfort level - just thought I dump this here so you have a data-point for potential changes.

• Change bottom bar navigation
• Use View pager

Describe the bug
It is possible to bypass recovery phrase confirmation screen without entering words.

To Reproduce
Steps to reproduce the behavior:

1. Go to Confirm Recovery Phrase screen
2. Just press "Finish"
3. The confirmation step is bypassed

Expected behavior
It should not be possible to bypass the screen. The "Finish" should only be clickable if it the recovery phrase is correct.

Smartphone (please complete the following information):

• Device: Pixel 2
• Android Version: 9
• App Version: 0.6.3

• Adjust design
• Adjust architecture
• Add tests

The static value should be replaced by the correct gas estimation.
Right now there's an issue in TestRPC where we need to multiply the estimated cost by at least 1.475x while on other nets we can simply multiply by 1.1.

Describe the bug
The Safe Recovery flow should have an introduction screen where the flow and the requirements are explained.

Smartphone (please complete the following information):

• Device: Pixel 2
• Android Version: 9
• App Version: 0.6.3

• Add option to copy wallet address
• Add option to share wallet address
• Add option to generate QR code of wallet address

Note: show a progressbar for QR code generation

For all tokens the balance should be fetched.

If one of the standard tokens has a 0 balance, don't display it.

Custom tokens should always be displayed.

Expected behavior

I can create a Safe

Actual behavior

App crashes after receiving the deposit. I assume at the point of Safe creation.

Steps to reproduce the behavior

• Clean install from crashlytics
• Go through onboarding
• Create Safe
• Fund Safe
• Wait for deposit to be detected
• Wait more
  💥

Afterwards, the app cannot be opened anymore, it crashes straight away.

Additional Information

It most likely this crash: https://fabric.io/gnosis/android/apps/pm.gnosis.heimdall.dev/issues/5b60b9c06007d59fcd609b0d

• Device: Moto G5S
• OS version: 7.1.1
• App version: 0.6.1-3-g0ac99c3-internal

RxAndroid 2.1.0 opens up a new API with async messaging. It'd be great to check the impact it has in the app.

• Display a card ("Costs:") that contains the value if present and the estimated gas limit and gas price
• Add possibility to change gas limit and gas price (on click on the card open dialog)
• (Optional) Add price in euro or dollars