GithubHelp home page GithubHelp logo

Comments (5)

nlordell avatar nlordell commented on June 1, 2024 1

Regarding:

Can we notify the SDK team in Slack about this?

from safe-smart-account.

akshay-ap avatar akshay-ap commented on June 1, 2024 1

Create npm release of 1.4.1, 1.3.0 builds?

Not required by SDK team. We will consider deploying old version if required.

from safe-smart-account.

akshay-ap avatar akshay-ap commented on June 1, 2024

Going with the second approach:

To do

Safe repositories that need to be updated for future releases:

Other potential other sources on Github that need to be updated for future releases: https://github.com/search?q=%40safe-global%2Fsafe-contracts&type=code&ref=advsearch

from safe-smart-account.

compojoom avatar compojoom commented on June 1, 2024

What does "easier discoverability" mean? Repos are not "app stores" where you look for the coolest name. Not sure what is requiring such a change, but I think it is useless and would just burden developers who would think - there is no new release where in reality the code lives under a new package name.

It's the same situation with @gnosis.pm/safe-contracts. There are projects that use those and never update to @safe-global/safe-contracts.

I hope that you've realy thought out that well.

from safe-smart-account.

mmv08 avatar mmv08 commented on June 1, 2024

Repos are not "app stores" where you look for the coolest name.

Yes, but at the same time, names should be descriptive. What does safe-contracts mean? Is it the safe{core} protocol? Are they safe token contracts? Is it the vesting contract? Is it modules? We grew past the stage where safe-contracts could only mean the account contracts.

It's the same situation with @gnosis.pm/safe-contracts. There are projects that use those and never update to @safe-global/safe-contracts.

They should pay more attention to the output when installing dependencies then. Usually, there's a message if the package has migrated to a new one.

I do not buy the argument because the existing tools allow us to perform the migration smoothly with aliases, warnings and stuff.

from safe-smart-account.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.