Comments (5)
Regarding:
Can we notify the SDK team in Slack about this?
from safe-smart-account.
Create npm release of 1.4.1, 1.3.0 builds?
Not required by SDK team. We will consider deploying old version if required.
from safe-smart-account.
Going with the second approach:
To do
- Rename repository
- Find and replace all links in this repository
- Update README.md: https://github.com/safe-global/safe-contracts/blob/b140318af6581e499506b11128a892e3f7a52aeb/README.md?plain=1#L1 and links as well
- Update links in CHANGELOG.md
- Update package name and links in package.json: https://github.com/safe-global/safe-contracts/blob/b140318af6581e499506b11128a892e3f7a52aeb/package.json#L2
- Create npm release of 1.4.1, 1.3.0 builds? Answer: No
Safe repositories that need to be updated for future releases:
- https://github.com/safe-global/safe-modules
- https://github.com/safe-global/safe-core-sdk
- Update links in docs: https://docs.safe.global/safe-smart-account/signatures/eip-1271#example-verify-signature
Other potential other sources on Github that need to be updated for future releases: https://github.com/search?q=%40safe-global%2Fsafe-contracts&type=code&ref=advsearch
from safe-smart-account.
What does "easier discoverability" mean? Repos are not "app stores" where you look for the coolest name. Not sure what is requiring such a change, but I think it is useless and would just burden developers who would think - there is no new release where in reality the code lives under a new package name.
It's the same situation with @gnosis.pm/safe-contracts. There are projects that use those and never update to @safe-global/safe-contracts.
I hope that you've realy thought out that well.
from safe-smart-account.
Repos are not "app stores" where you look for the coolest name.
Yes, but at the same time, names should be descriptive. What does safe-contracts mean? Is it the safe{core} protocol? Are they safe token contracts? Is it the vesting contract? Is it modules? We grew past the stage where safe-contracts could only mean the account contracts.
It's the same situation with @gnosis.pm/safe-contracts. There are projects that use those and never update to @safe-global/safe-contracts.
They should pay more attention to the output when installing dependencies then. Usually, there's a message if the package has migrated to a new one.
I do not buy the argument because the existing tools allow us to perform the migration smoothly with aliases, warnings and stuff.
from safe-smart-account.
Related Issues (20)
- LocalVerify Failures HOT 2
- Allow deleting queued transaction if single signature HOT 3
- Extend Safe With Additional Signing Schemes HOT 2
- Add an `ISafe` Interface For Interacting with Safes
- Bug report
- ,
- [Safe 1.5.0] Evaluate Posibility of moving `checkSignatures(bytes32, bytes, bytes)` into `Safe` HOT 3
- [Safe 1.5.0] `execTransactionFromModuleReturnData` Will Return Guard `returndata` HOT 3
- Provide developer utils for foundry
- Fallback function could be made payable.
- Evaluate strategies for reducing Safe code size
- Provide a way to identify whether a contract is a SAFE. HOT 1
- Expose revert message when internal transaction fails and `safeTxGas`/`gasPrice` are 0
- ProviderError: not enough gas supplied for intrinsic gas costs HOT 2
- Technical background for `onlyNonceZero` in `SafeToL2Migration`? HOT 6
- JSON Mix Up
- Figure out why Safe can't compile on 0.8 with IR optimizations HOT 2
- Imports Ordering for Contracts HOT 2
- Using `returndatasize()` directly in assembly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from safe-smart-account.