GithubHelp home page GithubHelp logo

Comments (6)

Uxio0 avatar Uxio0 commented on June 12, 2024 1

... but when there have not been any configuration changes, it should be allowed to exchange the singleton, IMHO.

There's no way for the indexer to know if there have been configuration changes or not as Safes cannot be indexed without events, that's the reasoning. We are very strict in the correctness on the data that we index and give the users, and that's why we cannot fall into asumptions.

from safe-smart-account.

pfedan avatar pfedan commented on June 12, 2024 1

There's no way for the indexer to know if there have been configuration changes or not as Safes cannot be indexed without events, that's the reasoning. We are very strict in the correctness on the data that we index and give the users, and that's why we cannot fall into asumptions.

Ah got it - thanks.

In my case, I hacked me through the safe tool-chain in order to fix my L2 safe with a nonce other than 0 (made one ERC20 transfer before).

Here's my journey (PSA: do not try this at home without knowing what you do)

I had to manipulate both the safe-cli and the SafeToL2Migration contract to omit the checks for nonce === 0, then deploy the contract and execute the modified update_version_to_l2 command in the safe-cli with my modified migration contract.

from safe-smart-account.

pfedan avatar pfedan commented on June 12, 2024 1

Sent a couple wei back and forth and it seemed fine. The only thing is that the TX nonces look a bit off in the UI - but I don't care 😁

image

from safe-smart-account.

pfedan avatar pfedan commented on June 12, 2024

I have found #685 and it is stated:

Only allow Safes with nonce=0, so they are unitialized and the L2 indexer is not missing some configuration changes going on between the update to L2

... but when there have not been any configuration changes, it should be allowed to exchange the singleton, IMHO.

from safe-smart-account.

pfedan avatar pfedan commented on June 12, 2024

tagging @Uxio0

from safe-smart-account.

Uxio0 avatar Uxio0 commented on June 12, 2024

We cannot guarantee them that your Safe will work propertly with our services/UI, but it's good as long as you understand that being an advanced user 😉

from safe-smart-account.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.