Comments (6)
... but when there have not been any configuration changes, it should be allowed to exchange the singleton, IMHO.
There's no way for the indexer to know if there have been configuration changes or not as Safes cannot be indexed without events, that's the reasoning. We are very strict in the correctness on the data that we index and give the users, and that's why we cannot fall into asumptions.
from safe-smart-account.
There's no way for the indexer to know if there have been configuration changes or not as Safes cannot be indexed without events, that's the reasoning. We are very strict in the correctness on the data that we index and give the users, and that's why we cannot fall into asumptions.
Ah got it - thanks.
In my case, I hacked me through the safe tool-chain in order to fix my L2 safe with a nonce other than 0 (made one ERC20 transfer before).
Here's my journey (PSA: do not try this at home without knowing what you do)
I had to manipulate both the safe-cli
and the SafeToL2Migration
contract to omit the checks for nonce === 0
, then deploy the contract and execute the modified update_version_to_l2
command in the safe-cli
with my modified migration contract.
from safe-smart-account.
Sent a couple wei back and forth and it seemed fine. The only thing is that the TX nonces look a bit off in the UI - but I don't care 😁
from safe-smart-account.
I have found #685 and it is stated:
Only allow Safes with nonce=0, so they are unitialized and the L2 indexer is not missing some configuration changes going on between the update to L2
... but when there have not been any configuration changes, it should be allowed to exchange the singleton, IMHO.
from safe-smart-account.
tagging @Uxio0
from safe-smart-account.
We cannot guarantee them that your Safe will work propertly with our services/UI, but it's good as long as you understand that being an advanced user 😉
from safe-smart-account.
Related Issues (20)
- ,
- [Safe 1.5.0] Evaluate Posibility of moving `checkSignatures(bytes32, bytes, bytes)` into `Safe` HOT 3
- [Safe 1.5.0] `execTransactionFromModuleReturnData` Will Return Guard `returndata` HOT 3
- Provide developer utils for foundry
- Fallback function could be made payable.
- Evaluate strategies for reducing Safe code size
- Provide a way to identify whether a contract is a SAFE. HOT 1
- Expose revert message when internal transaction fails and `safeTxGas`/`gasPrice` are 0
- ProviderError: not enough gas supplied for intrinsic gas costs HOT 2
- Rename the repo to `safe-smart-account` HOT 5
- JSON Mix Up
- Figure out why Safe can't compile on 0.8 with IR optimizations HOT 2
- Imports Ordering for Contracts HOT 2
- Using `returndatasize()` directly in assembly HOT 1
- Compilation fails with solc 0.8.23 HOT 4
- LZ's `sendFrom()` produces insufficient gas error in tx simulation HOT 1
- zksync branch doesn't seem to contain correct zksync deployment scripts
- Signature verification does not enforce a maximum size on the signature bytes
- Split Guard into Module and Transaction Guard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from safe-smart-account.