safersocietygroup / cake.strongnametool Goto Github PK

For some reason the sn.exe tool path isn't found on my machine. I inspected the code, and it seems to expect that stuff is in the v7.0A folder, which I have:

I verified that the sn.exe file is there. However, it still fails to find it.

Would it be possible to maybe override the path using the Settings you pass to the Alias, or maybe make the Resolver a bit more robust and try alternative paths as well?

An error occurred when executing task 'strong-name-sign'.
Error: Cake.Core.CakeException: Failed to find sn.exe.
   at Cake.StrongNameTool.StrongNameResolver.GetPath()
   at Cake.StrongNameTool.StrongNameToolRunner.GetAlternativeToolPaths(StrongNameToolSettings settings)
   at Cake.Core.Tooling.Tool`1.GetToolPathObsolete(TSettings settings)
   at Cake.Core.Tooling.Tool`1.GetToolPath(TSettings settings)
   at Cake.Core.Tooling.Tool`1.RunProcess(TSettings settings, ProcessArgumentBuilder arguments, ProcessSettings processSettings)
   at Cake.Core.Tooling.Tool`1.Run(TSettings settings, ProcessArgumentBuilder arguments, ProcessSettings processSettings, Action`1 postAction)
   at Cake.Core.Tooling.Tool`1.Run(TSettings settings, ProcessArgumentBuilder arguments)
   at Cake.StrongNameTool.StrongNameReSignToolAliases.StrongNameReSign(ICakeContext context, IEnumerable`1 assemblies, StrongNameToolSettings settings)
   at Submission#0.<.ctor>b__17()
   at Cake.Core.CakeTaskBuilderExtensions.<>c__DisplayClass5_0.<Does>b__0(ICakeContext context)
   at Cake.Core.ActionTask.Execute(ICakeContext context)
   at Cake.Core.DefaultExecutionStrategy.Execute(CakeTask task, ICakeContext context)
   at Cake.Core.CakeEngine.ExecuteTask(ICakeContext context, IExecutionStrategy strategy, Stopwatch stopWatch, CakeTask task, CakeReport report)
   at Cake.Core.CakeEngine.RunTarget(ICakeContext context, IExecutionStrategy strategy, String target)
   at Cake.Scripting.BuildScriptHost.RunTarget(String target)
   at Submission#0..ctor(Session session, Object& submissionResult)
   at Submission#0.<Factory>(Session session)
   at Roslyn.Scripting.CommonScriptEngine.Execute[T](String code, String path, DiagnosticBag diagnostics, Session session, Boolean isInteractive)
   at Roslyn.Scripting.Session.Execute(String code)
   at Cake.Scripting.Roslyn.Stable.DefaultRoslynScriptSession.Execute(Script script)
   at Cake.Core.Scripting.ScriptRunner.Run(IScriptHost host, FilePath scriptPath, IDictionary`2 arguments)
   at Cake.Commands.BuildCommand.Execute(CakeOptions options)
   at Cake.CakeApplication.Run(CakeOptions options)
   at Cake.Program.Main()

Thanks again for creating this Cake Addin, we really appreciate the effort that you have put in to creating it.

We, the Cake Team, recently announced a new Cake Contrib Icon, details of which can be found here:

http://cakebuild.net/blog/2017/06/new-cake-contrib-icon

Would you consider changing the nuspec file for your NuGet Package to use this new Cake Contrib Icon? If so, the recommended URL to use is:

https://cdn.rawgit.com/cake-contrib/graphics/a5cf0f881c390650144b2243ae551d5b9f836196/png/cake-contrib-medium.png

Details of the above URL can be found in the repository here:

https://github.com/cake-contrib/graphics

Please let me know if you have any questions.

I found myself needing this ability in a recent project, so I thought I would add this. PR incoming.

Would be neat to have this repository in the cake-contrib organization.

I'm trying to incorporate StrongNameTool, but Cake does not allow because the addin references Cake 0.25. Would you be able to quickly update the reference and release another version? Thanks a lot.

Hi,

while using this, i noticed that one has to skipverification to use this addin, since its a little outdated. Would it be possible to update its references to a more recent (0.22 or better) version of cake?

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

• You are currently referencing Cake.Core 0.25.0. Please upgrade to 0.28.0
• The Cake.Core reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Core" Version="0.28.0" PrivateAssets="All" />
• Your addin should target netstandard2.0. Please note that there is no need to multi-target, netstandard2.0 is sufficient.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.

i.e. get your addin listed here:

http://cakebuild.net/addins

Have a look at this PR:

cake-build/website#152

This assumes that you have added XML Documentation to your addin, as described here:

http://cakebuild.net/docs/contributing/documentation

Let me know if you have any questions. Thanks!